Brion VIBBER has submitted this change and it was merged. Change subject: Bug 44646: Standardise account creation and login forms ......................................................................
Bug 44646: Standardise account creation and login forms While there clean up a regression with error messages from hamburger standardisation Change-Id: I71fbf2f976c587dd4c2123254a4064657943c8d1 --- M less/common/mf-navigation.less M less/specials/userlogin.less M stylesheets/common/mf-navigation.css M stylesheets/specials/userlogin.css 4 files changed, 23 insertions(+), 35 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less index 1f2d452..f8c8366 100644 --- a/less/common/mf-navigation.less +++ b/less/common/mf-navigation.less @@ -5,8 +5,8 @@ @overlayAlertSuccessColor: green; @overlayAlertErrorBorderColor: #D00; @overlayAlertErrorBackgroundColor: #FAE1E1; -@overlayAlertPadding: 8px; -@overlayBorderWidth: 2px; +@overlayAlertPadding: 0.5em 1em; +@overlayBorderWidth: 1px; @toastNotificationColor: #373737; #mw-mf-header form, @@ -319,12 +319,11 @@ .alert { padding: @overlayAlertPadding; - margin: 0 @searchBoxMarginLeft 0 @searchBoxMarginLeft; background-repeat: no-repeat; background-position: @overlayAlertPadding center; - margin-bottom: @overlayAlertPadding; + margin-bottom: 1em; min-height: 64px; - font-size: @baseFontSize * 1.3; + font-size: @baseFontSize; &.success { padding-left: ( 80px + @overlayAlertPadding ); diff --git a/less/specials/userlogin.less b/less/specials/userlogin.less index 2f64ec9..54dd5ce 100644 --- a/less/specials/userlogin.less +++ b/less/specials/userlogin.less @@ -37,11 +37,6 @@ } } -#mw-mf-login .headmsg { - margin-left: @searchBoxMarginLeft; - margin-right: @searchBoxMarginLeft; -} - #mw-mf-accountcreate { .alert { margin-left: 0; @@ -78,9 +73,11 @@ input.loginPassword, input.loginText { font-family: @fontFamily; - font-size: @baseFontSize * 1.25; + font-size: @baseFontSize * 0.9; .box-sizing(border-box); - .border-radius(0); + border: 1px solid #C9C9C9; + box-shadow: none; + .border-radius(5px); width: 100%; padding: ( @inputFontSize/2 ) ( @inputFontSize * 1.5 ) ( @inputFontSize/2 ) ( @overlayHeadingIndent ); } @@ -90,16 +87,13 @@ margin-top: 20px; display: block; } - - #wpLoginAttempt { - font-size: @baseFontSize * 1.3; - } } /* sign up form */ form#userlogin2 { input { + box-shadow: none; display: block; width: 100%; padding: 0; diff --git a/stylesheets/common/mf-navigation.css b/stylesheets/common/mf-navigation.css index bc263cb..ba87c81 100644 --- a/stylesheets/common/mf-navigation.css +++ b/stylesheets/common/mf-navigation.css @@ -392,21 +392,20 @@ margin: 0 5px; } .alert { - padding: 8px; - margin: 0 40px 0 40px; + padding: 0.5em 1em; background-repeat: no-repeat; - background-position: 8px center; - margin-bottom: 8px; + background-position: 0.5em 1em center; + margin-bottom: 1em; min-height: 64px; - font-size: 1.3em; + font-size: 1em; } .alert.success { - padding-left: 88px; - border: solid 2px #008000; + padding-left: 80px; + border: solid 1px #008000; background-image: url(images/success.png); } .alert.error { - border: solid 2px #dd0000; + border: solid 1px #dd0000; background-color: #fae1e1; } .alert h2 { diff --git a/stylesheets/specials/userlogin.css b/stylesheets/specials/userlogin.css index ca8620e..828e5dc 100644 --- a/stylesheets/specials/userlogin.css +++ b/stylesheets/specials/userlogin.css @@ -21,10 +21,6 @@ padding: 0.5em 1em; margin: 1em 0; } -#mw-mf-login .headmsg { - margin-left: 40px; - margin-right: 40px; -} #mw-mf-accountcreate .alert { margin-left: 0; margin-right: 0; @@ -54,14 +50,16 @@ table.user-login input.loginPassword, table.user-login input.loginText { font-family: "Helvetica Neue", "Helvetica", "Arial", sans-serif; - font-size: 1.25em; + font-size: 0.9em; -moz-box-sizing: border-box; -o-box-sizing: border-box; -webkit-box-sizing: border-box; box-sizing: border-box; - -webkit-border-radius: 0; - -moz-border-radius: 0; - border-radius: 0; + border: 1px solid #C9C9C9; + box-shadow: none; + -webkit-border-radius: 5px; + -moz-border-radius: 5px; + border-radius: 5px; width: 100%; padding: 1em 3em 1em 0.4em; } @@ -70,11 +68,9 @@ margin-top: 20px; display: block; } -table.user-login #wpLoginAttempt { - font-size: 1.3em; -} /* sign up form */ form#userlogin2 input { + box-shadow: none; display: block; width: 100%; padding: 0; -- To view, visit https://gerrit.wikimedia.org/r/51623 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71fbf2f976c587dd4c2123254a4064657943c8d1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits