awjrichards has submitted this change and it was merged. Change subject: Bug 45378: Fix watchlist star jump ......................................................................
Bug 45378: Fix watchlist star jump Negative margins are bad mkay. Change-Id: Ide263f75679c5ed8093d6a21fdbdbb9d4d915b7b --- M less/modules/mf-watchstar.less M stylesheets/modules/mf-watchstar.css 2 files changed, 10 insertions(+), 6 deletions(-) Approvals: awjrichards: Verified; Looks good to me, approved diff --git a/less/modules/mf-watchstar.less b/less/modules/mf-watchstar.less index 5f81d90..c7f3863 100644 --- a/less/modules/mf-watchstar.less +++ b/less/modules/mf-watchstar.less @@ -28,10 +28,12 @@ li a.watch-this-article { right: @contentMarginRight; - top: 50%; - height: @searchResultPaddingVertical * 2; + top: 0; + bottom: 0; + height: 100%; width: @searchResultPaddingVertical * 2; - margin: -(@watchThisArticleSize / 2 + 1) 0 0; + background-position: center center; + margin: 0; } #mw-mf-menu-page { diff --git a/stylesheets/modules/mf-watchstar.css b/stylesheets/modules/mf-watchstar.css index 38d948a..8b6cc29 100644 --- a/stylesheets/modules/mf-watchstar.css +++ b/stylesheets/modules/mf-watchstar.css @@ -25,10 +25,12 @@ } li a.watch-this-article { right: 23px; - top: 50%; - height: 24px; + top: 0; + bottom: 0; + height: 100%; width: 24px; - margin: -12px 0 0; + background-position: center center; + margin: 0; } #mw-mf-menu-page a.watch-this-article { position: absolute; -- To view, visit https://gerrit.wikimedia.org/r/51324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide263f75679c5ed8093d6a21fdbdbb9d4d915b7b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: JGonera <jgon...@wikimedia.org> Gerrit-Reviewer: awjrichards <aricha...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits