Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/51804
Change subject: Update for new guiders cookie settings.
......................................................................
Update for new guiders cookie settings.
* Default changeCookie to true.
* Default to false for single-page tours.
* Bumps submodule for this feature.
Change-Id: I404bad9f19ef6be7acab41604c199fb032b2aedd
---
M modules/ext.guidedTour.lib.js
M modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GuidedTour
refs/changes/04/51804/1
diff --git a/modules/ext.guidedTour.lib.js b/modules/ext.guidedTour.lib.js
index 33c6bfc..4c40b3c 100644
--- a/modules/ext.guidedTour.lib.js
+++ b/modules/ext.guidedTour.lib.js
@@ -635,6 +635,7 @@
// cookie the users when they are in the tour
guiders.cookie = mw.config.get( 'wgCookiePrefix' ) + '-mw-tour';
guiders.cookieParams = { path: '/' };
+ guiders._defaultSettings.changeCookie = true;
// Don't show X button
guiders._defaultSettings.xButton = false;
@@ -1124,7 +1125,7 @@
if ( tourSpec.isSinglePage ) {
// TODO (mattflaschen, 2013-02-12): This should
be specific to the current tour. See
https://bugzilla.wikimedia.org/show_bug.cgi?id=44924
- guiders.cookie = "";
+ defaults.changeCookie = false;
defaults.showEndTour = false;
}
diff --git
a/modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule
b/modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule
index 7d86ef3..5006f47 160000
--- a/modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule
+++ b/modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule
-Subproject commit 7d86ef3ac4896bcae553891d8c2faf02b643320a
+Subproject commit 5006f47e63fd3743729105486b2a5f10d50d99f1
--
To view, visit https://gerrit.wikimedia.org/r/51804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I404bad9f19ef6be7acab41604c199fb032b2aedd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GuidedTour
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
