jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348442 )
Change subject: MediaWiki theme: Fix IE 7 oversized buttons
......................................................................
MediaWiki theme: Fix IE 7 oversized buttons
Fixing IE 7 wrong, oversized rendering due to false `min-height`
interpretation. Rely only on `padding` with unchanged calculation result.
Bug: T124905
Change-Id: I8420c088339ccfe0b7b4b6f921a8488a87dcc7ca
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
2 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 8b51404..49cf417 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -131,6 +131,7 @@
@padding-horizontal-input-text: 8 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
@padding-vertical-label: 4 / @oo-ui-font-size-browser /
@oo-ui-font-size-default; // equals `0.3125em`≈`4px`
@padding-top-default: 8 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
// equals `0.625em`≈`8px`
+@padding-top-icon-indicator: 30 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
@padding-top-menu: 9 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
@padding-bottom-default: 7 / @oo-ui-font-size-browser /
@oo-ui-font-size-default; // equals `0.547em`≈`7px`
@padding-bottom-menu: 8 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
diff --git a/src/themes/mediawiki/elements.less
b/src/themes/mediawiki/elements.less
index 008f86b..ff51236 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -211,14 +211,16 @@
&-framed {
> .oo-ui-buttonElement-button {
- min-height: @min-height-widget-default;
border-radius: @border-radius-default;
- padding: @padding-default;
+ padding-left: @padding-horizontal-default;
+ padding-right: @padding-horizontal-default;
}
&.oo-ui-iconElement {
// Icon (-only) framed
> .oo-ui-buttonElement-button {
+ padding-top: @padding-top-icon-indicator;
+ padding-bottom: 0;
padding-left: @padding-start-icon-only;
> .oo-ui-iconElement-icon {
@@ -242,7 +244,9 @@
&.oo-ui-indicatorElement {
// Indicator (-only) framed
> .oo-ui-buttonElement-button {
+ padding-top: @padding-top-icon-indicator;
padding-right: @padding-start-indicator-only;
+ padding-bottom: 0;
> .oo-ui-indicatorElement-indicator {
right: @start-framed-indicator-only;
@@ -258,6 +262,13 @@
}
}
+ &.oo-ui-labelElement {
+ > .oo-ui-buttonElement-button {
+ padding-top: @padding-top-default;
+ padding-bottom: @padding-bottom-default;
+ }
+ }
+
&.oo-ui-widget-disabled {
> .oo-ui-buttonElement-button {
background-color:
@background-color-disabled-filled;
--
To view, visit https://gerrit.wikimedia.org/r/348442
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8420c088339ccfe0b7b4b6f921a8488a87dcc7ca
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
