Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/51830
Change subject: Internationalize red-link-title parsing.
......................................................................
Internationalize red-link-title parsing.
Change-Id: I52dd52b4b66c93d7505054e9adc4a40c11b6bade
---
M GettingStarted.php
M resources/ext.gettingstarted.openTask.js
2 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/30/51830/1
diff --git a/GettingStarted.php b/GettingStarted.php
index b91b047..fbe4f38 100644
--- a/GettingStarted.php
+++ b/GettingStarted.php
@@ -58,11 +58,15 @@
'dependencies' => array(
'jquery.cookie',
'jquery.json',
+ 'jquery.mwExtension', // $.escapeRE
'mediawiki.Title',
'mediawiki.user',
'ext.Experiments.lib',
'ext.postEdit',
'schema.GettingStarted',
+ ),
+ 'messages' => array(
+ 'red-link-title'
)
) + $gettingStartedModuleInfo;
diff --git a/resources/ext.gettingstarted.openTask.js
b/resources/ext.gettingstarted.openTask.js
index 0b432ef..c036161 100644
--- a/resources/ext.gettingstarted.openTask.js
+++ b/resources/ext.gettingstarted.openTask.js
@@ -208,10 +208,17 @@
}
$returnTo.stall( 'click', function () {
- // XXX i18n, derive this from red-link-title?
- // I haven't seen other junk in the title of the
returnTo link, such as
- // query string.
- article = returnToTitle.replace( ' (page does not
exist)', '');
+ // Access the map directly, since we're processing it
unusually.
+ var redLinkTitle = mw.messages.get( 'red-link-title' ),
+ redLinkRegexText,
+ redLinkRegex;
+
+ redLinkRegexText = $.escapeRE( redLinkTitle );
+ // Replace escaped $1 with capturing group for one or
more characters
+ redLinkRegexText = redLinkRegexText.replace( '\\\$1',
'(.+)' );
+ redLinkRegex = new RegExp( '^' + redLinkRegexText + '$'
);
+
+ article = returnToTitle.match( redLinkRegex )[1];
mw.eventLog.logEvent( 'GettingStarted', {
action : 'gettingstarted-click',
funnel : 'returnto',
--
To view, visit https://gerrit.wikimedia.org/r/51830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52dd52b4b66c93d7505054e9adc4a40c11b6bade
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: feature/gettingstartedv2
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
