Bartosz Dziewoński has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348993 )
Change subject: Do not use role=menu/menuitem for MenuSelectWidget/MenuOptionWidget ...................................................................... Do not use role=menu/menuitem for MenuSelectWidget/MenuOptionWidget They will now use role=listbox/option from SelectWidget/OptionWidget. The difference is a bit unclear, but I think listbox is more appropriate. Per https://www.w3.org/TR/wai-aria/roles: "A menu is often a list of common actions or functions that the user can invoke. The menu role is appropriate when a list of menu items is presented in a manner similar to a menu on a desktop application." Usually, MenuSelectWidget items do not correspond to user actions (they are just values), and it's not really a desktop-like menu (that sounds more like our ListToolGroup and other toolbar stuff). And for a more practical consideration: a role=combobox widget (like our ComboBoxInputWidget) can only be paired with a role=listbox list, not with a role=menu one. Bug: T149654 Change-Id: Ib9894ef9c70132e1d820bfa3815e47e5160d7ecd --- M src/widgets/MenuOptionWidget.js M src/widgets/MenuSelectWidget.js 2 files changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/93/348993/1 diff --git a/src/widgets/MenuOptionWidget.js b/src/widgets/MenuOptionWidget.js index 427d1f3..a9d5009 100644 --- a/src/widgets/MenuOptionWidget.js +++ b/src/widgets/MenuOptionWidget.js @@ -16,9 +16,7 @@ OO.ui.MenuOptionWidget.parent.call( this, config ); // Initialization - this.$element - .attr( 'role', 'menuitem' ) - .addClass( 'oo-ui-menuOptionWidget' ); + this.$element.addClass( 'oo-ui-menuOptionWidget' ); }; /* Setup */ diff --git a/src/widgets/MenuSelectWidget.js b/src/widgets/MenuSelectWidget.js index 637271b..de8d457 100644 --- a/src/widgets/MenuSelectWidget.js +++ b/src/widgets/MenuSelectWidget.js @@ -64,9 +64,7 @@ this.highlightOnFilter = !!config.highlightOnFilter; // Initialization - this.$element - .addClass( 'oo-ui-menuSelectWidget' ) - .attr( 'role', 'menu' ); + this.$element.addClass( 'oo-ui-menuSelectWidget' ); // Initially hidden - using #toggle may cause errors if subclasses override toggle with methods // that reference properties not initialized at that time of parent class construction -- To view, visit https://gerrit.wikimedia.org/r/348993 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9894ef9c70132e1d820bfa3815e47e5160d7ecd Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
