HaeB has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349140 )
Change subject: Fix iOS app detection for monthly and daily uniques
......................................................................
Fix iOS app detection for monthly and daily uniques
Add detection of 'iOS' (in addition to 'iPhone') in user agent,
to accord for a change dating around September 2016
Bug: T163403
Change-Id: I38c0417232e5ea47376f0b35c0e900866cbbba10
---
M oozie/mobile_apps/uniques/daily/generate_uniques_daily.hql
M oozie/mobile_apps/uniques/monthly/generate_uniques_monthly.hql
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery
refs/changes/40/349140/1
diff --git a/oozie/mobile_apps/uniques/daily/generate_uniques_daily.hql
b/oozie/mobile_apps/uniques/daily/generate_uniques_daily.hql
index b1b5dac..bd600cd 100644
--- a/oozie/mobile_apps/uniques/daily/generate_uniques_daily.hql
+++ b/oozie/mobile_apps/uniques/daily/generate_uniques_daily.hql
@@ -56,7 +56,7 @@
year,
month,
day,
- CASE WHEN user_agent LIKE('%iPhone%') THEN 'iOS' ELSE 'Android' END AS
platform,
+ CASE WHEN (user_agent LIKE '%iOS%' OR user_agent LIKE '%iPhone%') THEN
'iOS' ELSE 'Android' END AS platform,
COALESCE(x_analytics_map['wmfuuid'],
parse_url(concat('http://bla.org/woo/', uri_query), 'QUERY',
'appInstallID')) AS uuid
FROM ${source_table}
diff --git a/oozie/mobile_apps/uniques/monthly/generate_uniques_monthly.hql
b/oozie/mobile_apps/uniques/monthly/generate_uniques_monthly.hql
index 9954a48..c6b36a4 100644
--- a/oozie/mobile_apps/uniques/monthly/generate_uniques_monthly.hql
+++ b/oozie/mobile_apps/uniques/monthly/generate_uniques_monthly.hql
@@ -55,7 +55,7 @@
SELECT
year,
month,
- CASE WHEN user_agent LIKE('%iPhone%') THEN 'iOS' ELSE 'Android' END AS
platform,
+ CASE WHEN (user_agent LIKE '%iOS%' OR user_agent LIKE '%iPhone%') THEN
'iOS' ELSE 'Android' END AS platform,
COALESCE(x_analytics_map['wmfuuid'],
parse_url(concat('http://bla.org/woo/', uri_query), 'QUERY',
'appInstallID')) AS uuid
FROM ${source_table}
--
To view, visit https://gerrit.wikimedia.org/r/349140
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c0417232e5ea47376f0b35c0e900866cbbba10
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: HaeB <tba...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
