Ema has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349188 )

Change subject: cache_upload: don't cache tiny objects at the backend layer
......................................................................

cache_upload: don't cache tiny objects at the backend layer

Don not cache objects with  CL < 256B at the backend layer.
Full rationale here: T145661#3197012.

Bug: T145661
Change-Id: I74688d43748a5b1eaf0d3ed2a763b3d093f5f109
---
M modules/varnish/templates/upload-backend.inc.vcl.erb
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/88/349188/1

diff --git a/modules/varnish/templates/upload-backend.inc.vcl.erb 
b/modules/varnish/templates/upload-backend.inc.vcl.erb
index 66fd12a..96acf70 100644
--- a/modules/varnish/templates/upload-backend.inc.vcl.erb
+++ b/modules/varnish/templates/upload-backend.inc.vcl.erb
@@ -56,6 +56,13 @@
 sub cluster_be_backend_response_early { }
 
 sub cluster_be_backend_response {
+       // hit-for-pass objects < 256B size (T145661)
+       if (std.integer(beresp.http.Content-Length, 256) < 256) {
+               set beresp.http.X-CDIS = "pass";
+               set beresp.uncacheable = true;
+               return (deliver);
+       }
+
        call pick_stevedore;
 
        if (beresp.http.Content-Range) {

-- 
To view, visit https://gerrit.wikimedia.org/r/349188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74688d43748a5b1eaf0d3ed2a763b3d093f5f109
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to