jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/349179 )
Change subject: Add missing newline at end of maintenance output
......................................................................
Add missing newline at end of maintenance output
The maintenance/UpdateConstraintstable.php script emits ASCII terminal
escape sequences to overwrite its output each time it’s updated, so the
final output is only one line with the final count of inserted rows.
However, if no line break is printed at the end, then upon script
termination the prompt is printed right after the output, instead of on
a new line.
Change-Id: I323f012bee369f60779094b18b7b2198bda8eb00
---
M maintenance/UpdateConstraintsTable.php
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/maintenance/UpdateConstraintsTable.php
b/maintenance/UpdateConstraintsTable.php
index 0c350fe..f66bda5 100644
--- a/maintenance/UpdateConstraintsTable.php
+++ b/maintenance/UpdateConstraintsTable.php
@@ -70,6 +70,9 @@
$accumulator = array();
if ( $data === false ) {
+ if ( !$this->isQuiet() ) {
+ $this->output( "\n" );
+ }
break;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/349179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I323f012bee369f60779094b18b7b2198bda8eb00
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
