jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/349183 )
Change subject: Fix EditPage button/input accessors on PageObject ...................................................................... Fix EditPage button/input accessors on PageObject The DOM was changed again in https://gerrit.wikimedia.org/r/#/c/348765/ and input elements where used for the buttons. Bug: T163193 Change-Id: I910a31a30d5569aab69dc2e5f81b377b6d867f64 --- M tests/browser/features/support/pages/edit_page.rb 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/support/pages/edit_page.rb b/tests/browser/features/support/pages/edit_page.rb index 7ff6b47..89ccf1b 100644 --- a/tests/browser/features/support/pages/edit_page.rb +++ b/tests/browser/features/support/pages/edit_page.rb @@ -2,7 +2,7 @@ include PageObject text_area(:edit_page_content, id: 'wpTextbox1') - button(:preview_button, css: '#wpPreview > button') - button(:show_changes_button, css: '#wpDiff > button') - button(:save_button, css: '#wpSave > button') + button(:preview_button, css: '#wpPreview > input') + button(:show_changes_button, css: '#wpDiff > input') + button(:save_button, css: '#wpSave > input') end -- To view, visit https://gerrit.wikimedia.org/r/349183 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I910a31a30d5569aab69dc2e5f81b377b6d867f64 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: WMDE-Fisch <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Bartosz Dziewoński <[email protected]> Gerrit-Reviewer: Jforrester <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
