Hello Zfilipin, Hashar, Sbisson, jenkins-bot, Jdlrobson,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/349230

to review the following change.


Change subject: Revert "Disable Cucumber scenarios that are broken in daily 
Jenkins jobs"
......................................................................

Revert "Disable Cucumber scenarios that are broken in daily Jenkins jobs"

This reverts commit 55207da09827f34a037570155bcea92f45d74505.

Currently I see no reason why these tests should be skipped. Furthermore at 
least the edit_page.feature test could have avoided 
https://phabricator.wikimedia.org/T163193.

Change-Id: I2b7903dc6cc446990ab4ffb7dee6e0c9e84f5e3e
---
M tests/browser/features/edit_page.feature
M tests/browser/features/view_history.feature
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/30/349230/1

diff --git a/tests/browser/features/edit_page.feature 
b/tests/browser/features/edit_page.feature
index 0a5d3cd..ade6914 100644
--- a/tests/browser/features/edit_page.feature
+++ b/tests/browser/features/edit_page.feature
@@ -1,4 +1,4 @@
-@chrome @firefox @skip @vagrant
+@chrome @firefox @vagrant
 Feature: Edit Page
 
   Scenario: Create and edit page
diff --git a/tests/browser/features/view_history.feature 
b/tests/browser/features/view_history.feature
index 8e72bcf..95136d2 100644
--- a/tests/browser/features/view_history.feature
+++ b/tests/browser/features/view_history.feature
@@ -1,4 +1,4 @@
-@chrome @firefox @skip @vagrant
+@chrome @firefox @vagrant
 Feature: View History
 
   Scenario: Edit page and view history

-- 
To view, visit https://gerrit.wikimedia.org/r/349230
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b7903dc6cc446990ab4ffb7dee6e0c9e84f5e3e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to