Alexandros Kosiaris has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349409 )
Change subject: Avoid double hiera lookups in puppetmaster::frontend
......................................................................
Avoid double hiera lookups in puppetmaster::frontend
Just reuse the already looked up variable $servers
Change-Id: If8150e3f6e60e33e96e78e9be0ed325de00306b5
---
M modules/role/manifests/puppetmaster/frontend.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/09/349409/1
diff --git a/modules/role/manifests/puppetmaster/frontend.pp
b/modules/role/manifests/puppetmaster/frontend.pp
index c70bdc6..c6b52d2 100644
--- a/modules/role/manifests/puppetmaster/frontend.pp
+++ b/modules/role/manifests/puppetmaster/frontend.pp
@@ -75,7 +75,7 @@
port => 8140,
}
- $puppetmaster_frontend_ferm = join(keys(hiera('puppetmaster::servers')), '
')
+ $puppetmaster_frontend_ferm = join(keys($servers), ' ')
ferm::service { 'ssh_puppet_merge':
proto => 'tcp',
port => '22',
--
To view, visit https://gerrit.wikimedia.org/r/349409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8150e3f6e60e33e96e78e9be0ed325de00306b5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
