jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/349673 )
Change subject: build: add grunt-contrib-jshint ...................................................................... build: add grunt-contrib-jshint See T119973 Change-Id: I0dbabe628b2f131e05b8966345aabdd897db5757 --- M Gruntfile.js M package.json 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/Gruntfile.js b/Gruntfile.js index 5efa53c..438ac4e 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -1,5 +1,6 @@ module.exports = function ( grunt ) { grunt.loadNpmTasks( 'grunt-jsonlint' ); + grunt.loadNpmTasks( 'grunt-contrib-jshint' ); grunt.loadNpmTasks( 'grunt-banana-checker' ); grunt.loadNpmTasks( 'grunt-stylelint' ); @@ -7,6 +8,13 @@ banana: { all: [ 'i18n/', + ] + }, + jshint: { + all: [ + '**/*.js', + '!node_modules/**', + '!vendor/**' ] }, jsonlint: { @@ -25,7 +33,7 @@ } } ); - grunt.registerTask( 'lint', ['jsonlint', 'banana', 'stylelint'] ); + grunt.registerTask( 'lint', ['jsonlint', 'banana', 'jshint', 'stylelint'] ); grunt.registerTask( 'test', ['lint'] ); grunt.registerTask( 'default', ['test'] ); }; diff --git a/package.json b/package.json index d399a6d..f806475 100644 --- a/package.json +++ b/package.json @@ -2,6 +2,7 @@ "devDependencies": { "grunt": "1.0.1", "grunt-banana-checker": "0.5.0", + "grunt-contrib-jshint": "1.1.0", "grunt-jsonlint": "1.1.0", "grunt-stylelint": "0.6.0", "stylelint-config-wikimedia": "0.4.1" -- To view, visit https://gerrit.wikimedia.org/r/349673 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dbabe628b2f131e05b8966345aabdd897db5757 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SecurePoll Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits