Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349779 )

Change subject: Run RebuildTitleKeys as a db update maintenance script
......................................................................

Run RebuildTitleKeys as a db update maintenance script

DatabaseUpdater::$maintenance is protected since cd40724c5e8, hence we
can no more get it to runChild() the RebuildTitleKeys script that
generates the keys.

Causes:

Fatal error: Cannot access protected property MysqlUpdater::$maintenance
in extensions/TitleKey/TitleKey_body.php on line 148

Instead use addPostDatabaseUpdateMaintenance() to register the
maintenance script.

Bug: T163617
Change-Id: I152a2fd059b87cd0947b2ca40841c9daf9f84cb7
---
M TitleKey_body.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TitleKey 
refs/changes/79/349779/1

diff --git a/TitleKey_body.php b/TitleKey_body.php
index ed8215e..87a1d25 100644
--- a/TitleKey_body.php
+++ b/TitleKey_body.php
@@ -129,6 +129,8 @@
         */
        public static function schemaUpdates( $updater = null ) {
                $updater->addExtensionUpdate( array( array( __CLASS__, 
'runUpdates' ) ) );
+               require_once __DIR__.'/rebuildTitleKeys.php';
+               $updater->addPostDatabaseUpdateMaintenance( 'RebuildTitleKeys' 
);
                return true;
        }
 
@@ -145,8 +147,6 @@
                        }
 
                        $updater->output( "ok.\n" );
-                       $task = $updater->maintenance->runChild( 
'RebuildTitleKeys' );
-                       $task->execute();
                }
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/349779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I152a2fd059b87cd0947b2ca40841c9daf9f84cb7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TitleKey
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to