Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349792 )
Change subject: Streamline dec to hex color calculation
......................................................................
Streamline dec to hex color calculation
This avoids the "33" which happens to be the only hex number in the
entire code.
Change-Id: I3e22e3315b8d643e071441bfd1c8a5c21283beb8
---
M utils/StatsTable.php
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/92/349792/1
diff --git a/utils/StatsTable.php b/utils/StatsTable.php
index fb46fb8..4d78d2d 100644
--- a/utils/StatsTable.php
+++ b/utils/StatsTable.php
@@ -89,17 +89,17 @@
if ( $v < 128 ) {
// Red to Yellow
- $red = sprintf( '%02X', ( 0.26 * $v ) + 221 );
- $green = sprintf( '%02X', ( 1.33 * $v ) + 33 );
- $blue = '33';
+ $red = 0.26 * $v + 221;
+ $green = 1.33 * $v + 33;
+ $blue = 51;
} else {
// Yellow to Green
- $red = sprintf( '%02X', 2 * ( 255 - $v ) );
- $green = sprintf( '%02X', ( 0.22 * ( 255 - $v ) ) + 175
);
- $blue = sprintf( '%02X', ( 0.67 * $v ) - 34 );
+ $red = 2 * ( 255 - $v );
+ $green = 0.22 * ( 255 - $v ) + 175;
+ $blue = 0.67 * $v - 34;
}
- return $red . $green . $blue;
+ return sprintf( '%02X%02X%02X', $red, $green, $blue );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/349792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e22e3315b8d643e071441bfd1c8a5c21283beb8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
