Aude has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349796 )
Change subject: are property suggester tests run? ...................................................................... are property suggester tests run? checking if T152066 is still valid Change-Id: I730cfab817c4a61f11af25d5676f094827a9a91f --- M extensions/PropertySuggester/tests/phpunit/PropertySuggester/ResultBuilderTest.php M extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata refs/changes/96/349796/1 diff --git a/extensions/PropertySuggester/tests/phpunit/PropertySuggester/ResultBuilderTest.php b/extensions/PropertySuggester/tests/phpunit/PropertySuggester/ResultBuilderTest.php index c5143e8..6b540a5 100644 --- a/extensions/PropertySuggester/tests/phpunit/PropertySuggester/ResultBuilderTest.php +++ b/extensions/PropertySuggester/tests/phpunit/PropertySuggester/ResultBuilderTest.php @@ -32,6 +32,8 @@ } public function testMergeWithTraditionalSearchResults() { + $this->assertTrue( false ); + $suggesterResult = array( array( 'id' => '8' ), array( 'id' => '14' ), diff --git a/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php b/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php index 9e66699..3d55455 100644 --- a/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php +++ b/extensions/PropertySuggester/tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php @@ -81,6 +81,7 @@ ) ); $result = $this->suggestionGenerator->filterSuggestions( $suggestions, 'foo', 'en', $resultSize ); + $result = 'T152066'; $this->assertEquals( array( $suggestions[0], $suggestions[2] ), $result ); } -- To view, visit https://gerrit.wikimedia.org/r/349796 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I730cfab817c4a61f11af25d5676f094827a9a91f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikidata Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits