jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/349132 )
Change subject: Set ARIA role=combobox on DropdownWidget and LookupElement too
......................................................................
Set ARIA role=combobox on DropdownWidget and LookupElement too
ARIA's definition of 'combobox' is a lot wider than ours, it applies
to pretty much everything with a dropdown list of items.
Change-Id: I63273b2c6ca97f9463d451acb40e48a9a776374b
---
M src/mixins/LookupElement.js
M src/widgets/DropdownWidget.js
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/src/mixins/LookupElement.js b/src/mixins/LookupElement.js
index 6834799..a95d3eb 100644
--- a/src/mixins/LookupElement.js
+++ b/src/mixins/LookupElement.js
@@ -59,6 +59,10 @@
} );
// Initialization
+ this.$input.attr( {
+ role: 'combobox',
+ 'aria-autocomplete': 'list'
+ } );
this.$element.addClass( 'oo-ui-lookupElement' );
this.lookupMenu.$element.addClass( 'oo-ui-lookupElement-menu' );
this.$overlay.append( this.lookupMenu.$element );
diff --git a/src/widgets/DropdownWidget.js b/src/widgets/DropdownWidget.js
index 5d675dc..b4fd091 100644
--- a/src/widgets/DropdownWidget.js
+++ b/src/widgets/DropdownWidget.js
@@ -93,6 +93,10 @@
// Initialization
this.$handle
.addClass( 'oo-ui-dropdownWidget-handle' )
+ .attr( {
+ role: 'combobox',
+ 'aria-autocomplete': 'list'
+ } )
.append( this.$icon, this.$label, this.$indicator );
this.$element
.addClass( 'oo-ui-dropdownWidget' )
--
To view, visit https://gerrit.wikimedia.org/r/349132
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63273b2c6ca97f9463d451acb40e48a9a776374b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
