BryanDavis has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350362 )
Change subject: Always cleanup manifest on stop
......................................................................
Always cleanup manifest on stop
Cleanup service.manifest state when `webservice stop` is called even if
no service is currently running.
Bug: T163355
Change-Id: Id689c3559dfbda6d2285f53c3570d295bbb193ef
---
M debian/changelog
M scripts/webservice
2 files changed, 8 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/operations/software/tools-webservice
refs/changes/62/350362/1
diff --git a/debian/changelog b/debian/changelog
index d80d2e1..f606bf3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,11 @@
toollabs-webservice (0.36) trusty; urgency=medium
+ * Always cleanup manifest on stop
+
+ -- Bryan Davis <bd...@wikimedia.org> Wed, 25 Apr 2017 04:01:13 +0000
+
+toollabs-webservice (0.36) trusty; urgency=medium
+
* Remove support for Precise
* PEP8 80ch line lenght limits
diff --git a/scripts/webservice b/scripts/webservice
index f79d43b..2775f12 100755
--- a/scripts/webservice
+++ b/scripts/webservice
@@ -144,9 +144,8 @@
elif args.action == 'stop':
if job.get_state() == Backend.STATE_STOPPED:
print('Your webservice is not running')
- sys.exit()
-
- stop(job, 'Stopping webservice')
+ else:
+ stop(job, 'Stopping webservice')
update_manifest(job, 'stop')
elif args.action == 'restart':
--
To view, visit https://gerrit.wikimedia.org/r/350362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id689c3559dfbda6d2285f53c3570d295bbb193ef
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/tools-webservice
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
