Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350373 )
Change subject: Split LexemeForm.equals QUnit test into two
......................................................................
Split LexemeForm.equals QUnit test into two
Change-Id: I7e944d6c9eb9fb4ac8a208a02b5bfc3d553eaf23
---
M tests/qunit/datamodel/LexemeForm.tests.js
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/73/350373/1
diff --git a/tests/qunit/datamodel/LexemeForm.tests.js
b/tests/qunit/datamodel/LexemeForm.tests.js
index ed6f4f5..a681449 100644
--- a/tests/qunit/datamodel/LexemeForm.tests.js
+++ b/tests/qunit/datamodel/LexemeForm.tests.js
@@ -28,38 +28,38 @@
var id = 'L123',
representation = 'foo',
form = newForm( id, representation ),
+ comparison = newForm( id, representation );
+
+ assert.equal( form.equals( comparison ), true );
+ } );
+
+ QUnit.test( 'not equals()', function ( assert ) {
+ var id = 'L123',
+ representation = 'foo',
+ form = newForm( id, representation ),
equalsDataProvider = [
{
- comparison: newForm( id, representation
),
- expectedResult: true,
- message: 'Same id, same representation'
- },
- {
comparison: newForm( id, 'bar' ),
- expectedResult: false,
message: 'same id, different
representation'
},
{
comparison: newForm( 'L234',
representation ),
- expectedResult: false,
message: 'different id, same
representation'
},
{
comparison: newForm( 'L234', 'bar' ),
- expectedResult: false,
message: 'different id, different
representation'
},
{
comparison: null,
- expectedResult: false,
message: 'not a LexemeForm object'
}
];
equalsDataProvider.forEach( function ( testData ) {
assert.equal(
- form.equals(testData.comparison),
- testData.expectedResult,
+ form.equals( testData.comparison ),
+ false,
testData.message
);
} );
--
To view, visit https://gerrit.wikimedia.org/r/350373
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e944d6c9eb9fb4ac8a208a02b5bfc3d553eaf23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
