Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/350409
to review the following change.
Change subject: Throw InvalidArgumentException in makeKnownLink on null
......................................................................
Throw InvalidArgumentException in makeKnownLink on null
This reverts commit e55e649b2295054178e55da9f3a30cfe91038d49.
Change-Id: I497a01654a56849439674fbdf12012109f636107
---
M includes/linker/LinkRenderer.php
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/09/350409/1
diff --git a/includes/linker/LinkRenderer.php b/includes/linker/LinkRenderer.php
index c203a16..83fdede 100644
--- a/includes/linker/LinkRenderer.php
+++ b/includes/linker/LinkRenderer.php
@@ -25,6 +25,7 @@
use Hooks;
use Html;
use HtmlArmor;
+use InvalidArgumentException;
use LinkCache;
use Linker;
use MediaWiki\MediaWikiServices;
@@ -280,8 +281,13 @@
* @return string
*/
public function makeKnownLink(
- LinkTarget $target, $text = null, array $extraAttribs = [],
array $query = []
+ $target, $text = null, array $extraAttribs = [], array $query =
[]
) {
+ if ( $target instanceof LinkTarget ) {
+ throw new InvalidArgumentException(
+ 'Argument 1 passed to ' . __METHOD__ . ' must
implement ' . LinkTarget::class
+ );
+ }
$classes = [];
if ( $target->isExternal() ) {
$classes[] = 'extiw';
--
To view, visit https://gerrit.wikimedia.org/r/350409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I497a01654a56849439674fbdf12012109f636107
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.29.0-wmf.20
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
