Addshore has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/350410 )
Change subject: Revert "Throw InvalidArgumentException in makeKnownLink on null"
......................................................................
Revert "Throw InvalidArgumentException in makeKnownLink on null"
This reverts commit 3a288fcdbb31cdcba95a1bf16895fd12495260b8.
Change-Id: I407575942b8182d66d5899d711825c30153a6a5f
---
M includes/linker/LinkRenderer.php
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Addshore: Verified; Looks good to me, approved
diff --git a/includes/linker/LinkRenderer.php b/includes/linker/LinkRenderer.php
index 5304ee1..c203a16 100644
--- a/includes/linker/LinkRenderer.php
+++ b/includes/linker/LinkRenderer.php
@@ -25,7 +25,6 @@
use Hooks;
use Html;
use HtmlArmor;
-use InvalidArgumentException;
use LinkCache;
use Linker;
use MediaWiki\MediaWikiServices;
@@ -281,13 +280,8 @@
* @return string
*/
public function makeKnownLink(
- $target, $text = null, array $extraAttribs = [], array $query =
[]
+ LinkTarget $target, $text = null, array $extraAttribs = [],
array $query = []
) {
- if ( !$target instanceof LinkTarget ) {
- throw new InvalidArgumentException(
- 'Argument 1 passed to ' . __METHOD__ . ' must
implement ' . LinkTarget::class
- );
- }
$classes = [];
if ( $target->isExternal() ) {
$classes[] = 'extiw';
--
To view, visit https://gerrit.wikimedia.org/r/350410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I407575942b8182d66d5899d711825c30153a6a5f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.29.0-wmf.20
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
