jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/350400 )
Change subject: Tests: clarified usage of addDBDataOnce
......................................................................
Tests: clarified usage of addDBDataOnce
The assignement in this function was misleading and unusable. In order
to state the total number, please use protected iFixtureTotal in your
tests
Change-Id: I412d267f37fdc6cde7222ce3eac8bc0e1bf732cf
---
M tests/BSApiExtJSStoreTestBase.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/BSApiExtJSStoreTestBase.php
b/tests/BSApiExtJSStoreTestBase.php
index ae458a4..d93ba8a 100644
--- a/tests/BSApiExtJSStoreTestBase.php
+++ b/tests/BSApiExtJSStoreTestBase.php
@@ -23,7 +23,8 @@
}
public function addDBDataOnce() {
- $this->iFixtureTotal = $this->createStoreFixtureData();
+ // Caution: this is only called once per testsuite, not per
test.
+ $this->createStoreFixtureData();
}
public function testSchema() {
--
To view, visit https://gerrit.wikimedia.org/r/350400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I412d267f37fdc6cde7222ce3eac8bc0e1bf732cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Mglaser <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
