Nikerabbit has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/349935 )
Change subject: mw.cx.ui.SectionTranslationUnit: Disconnect click handler
......................................................................
mw.cx.ui.SectionTranslationUnit: Disconnect click handler
Click handler to translate need to execute only once.
Change-Id: If2b70aba8c95af0dea8cef695b8ff6e03bf3889c
---
M modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Nikerabbit: Looks good to me, approved
diff --git a/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
b/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
index b575eed..431fbef 100644
--- a/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
+++ b/modules/ui/translationunits/mw.cx.ui.SectionTranslationUnit.js
@@ -11,9 +11,8 @@
mw.cx.ui.SectionTranslationUnit = function MwCxUiSectionTranslationUnit(
model, toolFactory, config ) {
mw.cx.ui.SectionTranslationUnit.super.call( this, model, toolFactory,
config );
mw.cx.ui.mixin.AlignableTranslationUnit.call( this );
- this.connect( this, {
- click: 'translate'
- } );
+ // Click handler to translate need to execute only once.
+ this.once( 'click', this.translate.bind( this ) );
};
/* Setup */
@@ -108,6 +107,7 @@
this.removeHighlight();
if ( !this.isTranslated() ) {
+ mw.log( '[CX] Translating section: ' + this );
// Adapt in general will be asynchronous operation
this.model.adapt();
this.setContent( this.model.targetDocument );
--
To view, visit https://gerrit.wikimedia.org/r/349935
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2b70aba8c95af0dea8cef695b8ff6e03bf3889c
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
