Harej has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351746 )

Change subject: Adding .pushPending() to certain process dialogs
......................................................................

Adding .pushPending() to certain process dialogs

This way, when buttons are pushed, they have a nice save animation
instead of just sitting there blankly.

Change-Id: Iafd1663f94d03cf059fec185e072aceac0cc1d59
---
M modules/ext.CollaborationKit.hubtheme.js
M modules/ext.CollaborationKit.list.ui.js
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit 
refs/changes/46/351746/1

diff --git a/modules/ext.CollaborationKit.hubtheme.js 
b/modules/ext.CollaborationKit.hubtheme.js
index e99bd8b..e727919 100644
--- a/modules/ext.CollaborationKit.hubtheme.js
+++ b/modules/ext.CollaborationKit.hubtheme.js
@@ -223,8 +223,8 @@
         */
        ImageProcessDialog.prototype.getActionProcess = function ( action ) {
                var dialog, fileTitle;
-
                dialog = this;
+               dialog.pushPending();
                if ( action ) {
                        return new OO.ui.Process( function () {
                                var fileObj, fileUrl, fileHeight, fileTitleObj;
diff --git a/modules/ext.CollaborationKit.list.ui.js 
b/modules/ext.CollaborationKit.list.ui.js
index 26a0574..3ad6636 100644
--- a/modules/ext.CollaborationKit.list.ui.js
+++ b/modules/ext.CollaborationKit.list.ui.js
@@ -187,6 +187,8 @@
                        dialog = this,
                        titleObj;
 
+               dialog.pushPending();
+
                if ( this.titleWidget instanceof mw.widgets.UserInputWidget ) {
                        titleObj = mw.Title.newFromText( 'User:' + title );
                        if ( titleObj ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/351746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafd1663f94d03cf059fec185e072aceac0cc1d59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Harej <jamesmh...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to