Anomie has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351871 )
Change subject: Call wfInitShellLocale() from Scribunto_LuaSandboxInterpreter
......................................................................
Call wfInitShellLocale() from Scribunto_LuaSandboxInterpreter
Lua is very sensitive to the locale in use. In LuaStandalone it'll
always use $wgShellLocale thanks to calls to wfEscapeShellArg(), but for
LuaSandbox we need to set it up explicitly since nothing else may have
done so.
Bug: T107128
Change-Id: Ib134aa6b674dda1626275c6ec36ff4fb9df8c064
---
M engines/LuaSandbox/Engine.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto
refs/changes/71/351871/1
diff --git a/engines/LuaSandbox/Engine.php b/engines/LuaSandbox/Engine.php
index 22eb1e5..6846f14 100644
--- a/engines/LuaSandbox/Engine.php
+++ b/engines/LuaSandbox/Engine.php
@@ -268,6 +268,11 @@
function __construct( $engine, array $options ) {
self::checkLuaSandboxVersion();
+ // Make sure $wgShellLocale is applied, otherwise we'll have
+ // inconsistent behavior depending on whether something else
did this
+ // or not.
+ wfInitShellLocale();
+
$this->engine = $engine;
$this->sandbox = new LuaSandbox;
$this->sandbox->setMemoryLimit( $options['memoryLimit'] );
--
To view, visit https://gerrit.wikimedia.org/r/351871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib134aa6b674dda1626275c6ec36ff4fb9df8c064
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Anomie <bjor...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
