jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351272 )
Change subject: Register MediaInfo talk namespace
......................................................................
Register MediaInfo talk namespace
As noticed in the comment T159709#3200587 talk page link currently
leads to the page in the main namespace.
For now always register talk namespace for MediaInfo pages. If there
is a need to allow disabling this namespace, this should be done
separately after planning how to actually do this.
Change-Id: I52ad13363beed2fc484bbcd6012c64b6290fd996
---
M extension.json
M tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php
2 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Lydia Pintscher: Looks good to me, but someone else must approve
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
Objections:
Thiemo Mättig (WMDE): There's a problem with this change, please improve
diff --git a/extension.json b/extension.json
index eaf05ef..3f14b02 100644
--- a/extension.json
+++ b/extension.json
@@ -10,7 +10,8 @@
"type": "wikibase",
"load_composer_autoloader": true,
"config": {
- "MediaInfoNamespace": 144
+ "MediaInfoNamespace": 144,
+ "MediaInfoNamespaceTalk": 145
},
"namespaces": [
{
@@ -18,6 +19,11 @@
"constant": "NS_MEDIAINFO",
"name": "MediaInfo",
"defaultcontentmodel": "wikibase-mediainfo"
+ },
+ {
+ "id": 145,
+ "constant": "NS_MEDIAINFO_TALK",
+ "name": "MediaInfo_talk"
}
],
"ExtensionMessagesFiles": {
diff --git a/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php
b/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php
index f7e7c52..76a1120 100644
--- a/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php
+++ b/tests/phpunit/mediawiki/WikibaseMediaInfoHooksTest.php
@@ -48,7 +48,10 @@
$namespaces = $language->getNamespaces();
$mediaInfoNS = $config->get( 'MediaInfoNamespace' );
+ $mediaInfoTalkNS = $config->get( 'MediaInfoNamespaceTalk' );
+
$this->assertArrayHasKey( $mediaInfoNS, $namespaces, 'MediaInfo
namespace' );
+ $this->assertArrayHasKey( $mediaInfoTalkNS, $namespaces,
'MediaInfo talk namespace' );
}
public function provideWikibaseEntityTypesHooks() {
--
To view, visit https://gerrit.wikimedia.org/r/351272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52ad13363beed2fc484bbcd6012c64b6290fd996
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseMediaInfo
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Lydia Pintscher <lydia.pintsc...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
