Muehlenhoff has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/352098 )

Change subject: dumps: Explicitly declare package dependencies for nfs-common 
and rpcbind
......................................................................


dumps: Explicitly declare package dependencies for nfs-common and rpcbind

Right now rpcbind and nfs-common are always installed during the initial
d-i base installation. We want to change that to reduce footprint and
only install in the roles where it's actually needed.

Bug: T106477

Change-Id: I7e79c9c45b64c36e719b3a36751a3f23c4fb6fec
---
M modules/dataset/manifests/nfs.pp
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Muehlenhoff: Looks good to me, approved
  ArielGlenn: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/modules/dataset/manifests/nfs.pp b/modules/dataset/manifests/nfs.pp
index 2acf223..d5cda51 100644
--- a/modules/dataset/manifests/nfs.pp
+++ b/modules/dataset/manifests/nfs.pp
@@ -20,9 +20,7 @@
         require => Package['nfs-kernel-server'],
     }
 
-    package { 'nfs-kernel-server':
-        ensure => present,
-    }
+    require_package('nfs-kernel-server', 'nfs-common', 'rpcbind')
 
     service { 'nfs-kernel-server':
         ensure    => $service_ensure,

-- 
To view, visit https://gerrit.wikimedia.org/r/352098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e79c9c45b64c36e719b3a36751a3f23c4fb6fec
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: ArielGlenn <ar...@wikimedia.org>
Gerrit-Reviewer: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to