jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351727 )
Change subject: MediaWiki theme: Bring styling to design spec in Safari/iOS
......................................................................
MediaWiki theme: Bring styling to design spec in Safari/iOS
Adding `-webkit-appearance: none;` where necessary and removing
`appearance` property as of the time being, it is not supported by
a single browser, while `-webkit-appearance` is the cross-browser supported
property (Webkit, Blink based browsers, Edge, UCBrowser, recent Firefox).
Also unifying comments.
Bug: T164436
Change-Id: I8d0dab0c50e70e06f8d64c15dbbfe4ed3c0592e8
---
M src/styles/widgets/TextInputWidget.less
M src/themes/mediawiki/widgets.less
2 files changed, 5 insertions(+), 7 deletions(-)
Approvals:
Prtksxna: Looks good to me, but someone else must approve
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/styles/widgets/TextInputWidget.less
b/src/styles/widgets/TextInputWidget.less
index ec62d0c..1b60524 100644
--- a/src/styles/widgets/TextInputWidget.less
+++ b/src/styles/widgets/TextInputWidget.less
@@ -13,9 +13,8 @@
.oo-ui-box-sizing( border-box );
}
- // IE 8-11 defaults `overflow` to `scroll`. Modern browsers use `auto`
textarea {
- overflow: auto;
+ overflow: auto; // Support: IE 8-11 defaults `overflow` to
`scroll`. Modern browsers use `auto`
resize: none;
}
@@ -34,15 +33,14 @@
// Normalize styling of `<input type=search>` and
// remove proprietary vendor UI extensions
[type='search'] {
- // Safari 5, Chrome
- -webkit-appearance: textfield;
+ -webkit-appearance: none; // Support: Safari/iOS `none` needed,
Chrome would accept `textfield` as well
- // IE 10-11, Edge 12+
+ // Support: IE 10-11, Edge 12+
&::-ms-clear {
display: none;
}
- // Safari, Chrome (Blink)
+ // Support: Safari, Chrome (Blink)
&::-webkit-search-decoration,
&::-webkit-search-cancel-button {
display: none;
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 6e68ba5..7a025dc 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -659,7 +659,6 @@
// Remove user agent styles
-webkit-appearance: none;
-moz-appearance: none;
- appearance: none;
.oo-ui-box-sizing( border-box );
border: @border-default;
border-radius: @border-radius-default;
@@ -1748,6 +1747,7 @@
input,
textarea {
+ -webkit-appearance: none; // Support: Safari/iOS
margin: 0;
font-size: inherit;
font-family: inherit;
--
To view, visit https://gerrit.wikimedia.org/r/351727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d0dab0c50e70e06f8d64c15dbbfe4ed3c0592e8
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
