jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/352214 )

Change subject: MenuSectionOptionWidget: Remove unsupported ARIA attribute
......................................................................


MenuSectionOptionWidget: Remove unsupported ARIA attribute

Removing empty `role` and misleading `aria-selected` attribute from
MenuSectionOptionWidget.

Change-Id: I196f566b6bd6b6b7ca53f5a1f189922d39842cb4
---
M src/widgets/MenuSectionOptionWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/widgets/MenuSectionOptionWidget.js 
b/src/widgets/MenuSectionOptionWidget.js
index 87273e5..72096e1 100644
--- a/src/widgets/MenuSectionOptionWidget.js
+++ b/src/widgets/MenuSectionOptionWidget.js
@@ -41,7 +41,7 @@
 
        // Initialization
        this.$element.addClass( 'oo-ui-menuSectionOptionWidget' )
-               .attr( 'role', '' );
+               .removeAttr( 'role aria-selected' );
 };
 
 /* Setup */

-- 
To view, visit https://gerrit.wikimedia.org/r/352214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I196f566b6bd6b6b7ca53f5a1f189922d39842cb4
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to