jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351527 )
Change subject: Follow-up 57a06a6: Use the same attribute name on read and on
write
......................................................................
Follow-up 57a06a6: Use the same attribute name on read and on write
Bug: T164054
Change-Id: I6770f6c91248fcd9ab39322413874e20a1b65552
(cherry picked from commit 486bbd76090919306f5cadbae0bd85eefc8500f1)
---
M modules/ve-mw/dm/metaitems/ve.dm.MWFlaggedMetaItem.js
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/dm/metaitems/ve.dm.MWFlaggedMetaItem.js
b/modules/ve-mw/dm/metaitems/ve.dm.MWFlaggedMetaItem.js
index d04011e..794b3e0 100644
--- a/modules/ve-mw/dm/metaitems/ve.dm.MWFlaggedMetaItem.js
+++ b/modules/ve-mw/dm/metaitems/ve.dm.MWFlaggedMetaItem.js
@@ -30,26 +30,26 @@
ve.dm.MWFlaggedMetaItem.static.matchTagNames = [ 'meta' ];
ve.dm.MWFlaggedMetaItem.static.toDataElement = function ( domElements ) {
- var type = domElements[ 0 ].getAttribute( 'property' );
+ var property = domElements[ 0 ].getAttribute( 'property' );
- if ( !type || this.matchRdfaTypes.indexOf( type ) === -1 ) {
+ if ( !property || this.matchRdfaTypes.indexOf( property ) === -1 ) {
// Fallback to first match if somehow unset
- type = this.matchRdfaTypes[ 0 ];
+ property = this.matchRdfaTypes[ 0 ];
}
- return { type: this.name, attributes: { type: type } };
+ return { type: this.name, attributes: { property: property } };
};
ve.dm.MWFlaggedMetaItem.static.toDomElements = function ( dataElement, doc ) {
var meta = doc.createElement( 'meta' ),
- type = OO.getProp( dataElement, 'attributes', 'property' );
+ property = OO.getProp( dataElement, 'attributes', 'property' );
- if ( !type || this.matchRdfaTypes.indexOf( type ) === -1 ) {
+ if ( !property || this.matchRdfaTypes.indexOf( property ) === -1 ) {
// Fallback to first item if somehow unset
- type = this.matchRdfaTypes[ 0 ];
+ property = this.matchRdfaTypes[ 0 ];
}
- meta.setAttribute( 'property', type );
+ meta.setAttribute( 'property', property );
return [ meta ];
};
--
To view, visit https://gerrit.wikimedia.org/r/351527
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6770f6c91248fcd9ab39322413874e20a1b65552
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.29.0-wmf.21
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
