Catrope has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352709 )
Change subject: Follow-up ba3cae5d887: deal with unserialize() returning false ...................................................................... Follow-up ba3cae5d887: deal with unserialize() returning false Change-Id: I5efdd81aa696ef8f7209980e909cb54c9e3ab9ef --- M fixT159372.php 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMaintenance refs/changes/09/352709/1 diff --git a/fixT159372.php b/fixT159372.php index 4c32d47..1d84145 100644 --- a/fixT159372.php +++ b/fixT159372.php @@ -36,7 +36,12 @@ foreach ( $iterator as $batch ) { foreach ( $batch as $row ) { try { - $reserialized = serialize( unserialize( $row->event_extra ) ); + $unserialized = unserialize( $row->event_extra ); + if ( !$unserialized ) { + $this->output( "Failed to unserialize event_id {$row->event_id}" ); + continue; + } + $reserialized = serialize( $unserialized ); $dbw->update( 'echo_event', [ 'event_extra' => $reserialized ], -- To view, visit https://gerrit.wikimedia.org/r/352709 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5efdd81aa696ef8f7209980e909cb54c9e3ab9ef Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikimediaMaintenance Gerrit-Branch: master Gerrit-Owner: Catrope <r...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits