jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/352733 )
Change subject: Check tags with ChangeTags::canCreateTag
......................................................................
Check tags with ChangeTags::canCreateTag
These are also user-provided tag names, so should be checked with
ChangeTags::canCreateTag, which is intended for that purpose.
This check also applies on edits.
Bug: T164133
Change-Id: Iaf161d538f225a86c7abf8a8a347de9169d781bf
---
M Views/AbuseFilterViewEdit.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Views/AbuseFilterViewEdit.php b/Views/AbuseFilterViewEdit.php
index 59d67a3..90be828 100644
--- a/Views/AbuseFilterViewEdit.php
+++ b/Views/AbuseFilterViewEdit.php
@@ -111,7 +111,9 @@
$bad = false;
foreach ( $actions['tag']['parameters'] as $tag
) {
$t = Title::makeTitleSafe(
NS_MEDIAWIKI, 'tag-' . $tag );
- if ( !$t ) {
+ if ( !$t ||
+ !ChangeTags::canCreateTag(
$tag, $user )->isOK() ) {
+
$bad = true;
}
--
To view, visit https://gerrit.wikimedia.org/r/352733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf161d538f225a86c7abf8a8a347de9169d781bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Catrope <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
