Aude has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/352823 )
Change subject: Fix the i18n message reference in the Copyright Notice on
NewEntity page
......................................................................
Fix the i18n message reference in the Copyright Notice on NewEntity page
With changes made in Ieeeb3740d32b9c5de2f00a56197d5ff6efc63aa3
the copyright notice on Special:NewItem, NewProperty, etc
referred to non-existing messages wikibase-newitem-submit,
wikibase-newproperty-submit, whereas the expected message
(ie. the message used for the label of the submit button on
Special:New* pages) is wikibase-newentity-submit.
Change-Id: Ieec0bf0d8a85c44af753736f4d92e0ef78527f2d
---
M repo/includes/Specials/SpecialNewEntity.php
M repo/includes/Specials/SpecialWikibaseRepoPage.php
2 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/23/352823/1
diff --git a/repo/includes/Specials/SpecialNewEntity.php
b/repo/includes/Specials/SpecialNewEntity.php
index 7b070b4..c229c3c 100644
--- a/repo/includes/Specials/SpecialNewEntity.php
+++ b/repo/includes/Specials/SpecialNewEntity.php
@@ -204,6 +204,13 @@
}
/**
+ * @return string HTML
+ */
+ protected function getCopyrightHTML() {
+ return $this->copyrightView->getHtml( $this->getLanguage(),
'wikibase-newentity-submit' );
+ }
+
+ /**
* @param EntityDocument $entity
*/
private function redirectToEntityPage( EntityDocument $entity ) {
diff --git a/repo/includes/Specials/SpecialWikibaseRepoPage.php
b/repo/includes/Specials/SpecialWikibaseRepoPage.php
index 017c141..01541c9 100644
--- a/repo/includes/Specials/SpecialWikibaseRepoPage.php
+++ b/repo/includes/Specials/SpecialWikibaseRepoPage.php
@@ -27,7 +27,7 @@
/**
* @var SpecialPageCopyrightView
*/
- private $copyrightView;
+ protected $copyrightView;
/**
* @var SummaryFormatter
--
To view, visit https://gerrit.wikimedia.org/r/352823
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieec0bf0d8a85c44af753736f4d92e0ef78527f2d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.30.0-wmf.1
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
