Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/352639 )
Change subject: graphite: use logrotate::conf for logrotate ...................................................................... graphite: use logrotate::conf for logrotate Change-Id: Ic18762b977618269ea083604b7ff6abc5ac76d3c --- M modules/graphite/manifests/web.pp 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/modules/graphite/manifests/web.pp b/modules/graphite/manifests/web.pp index 9f15e2a..dead85d 100644 --- a/modules/graphite/manifests/web.pp +++ b/modules/graphite/manifests/web.pp @@ -145,13 +145,9 @@ require => File['/usr/local/sbin/graphite-auth'], } - file { '/etc/logrotate.d/graphite-web': - ensure => present, - mode => '0444', - owner => 'root', - group => 'root', - source => 'puppet:///modules/graphite/graphite-web-logrotate', - require => File['/var/log/graphite-web'], + logrotate::conf { 'graphite-web': + ensure => present, + source => 'puppet:///modules/graphite/graphite-web-logrotate', } } -- To view, visit https://gerrit.wikimedia.org/r/352639 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic18762b977618269ea083604b7ff6abc5ac76d3c Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits