jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/352898 )
Change subject: TagMultiselectWidget: Fix keyboard navigation between items
......................................................................
TagMultiselectWidget: Fix keyboard navigation between items
Due to the missing parameter, when navigating from the input field to the
items, it always navigated to the "next" item (effectively the first one).
Change-Id: If3bdb0aed6eb8b04e8a7282477fe51c49f7d763b
---
M src/widgets/TagMultiselectWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/src/widgets/TagMultiselectWidget.js
b/src/widgets/TagMultiselectWidget.js
index f69361e..8d7f884 100644
--- a/src/widgets/TagMultiselectWidget.js
+++ b/src/widgets/TagMultiselectWidget.js
@@ -365,7 +365,7 @@
* a meta key like 'ctrl'
* @return {boolean} Whether to prevent defaults
*/
-OO.ui.TagMultiselectWidget.prototype.doInputArrow = function ( direction ) {
+OO.ui.TagMultiselectWidget.prototype.doInputArrow = function ( e, direction ) {
if (
this.inputPosition === 'inline' &&
!this.isEmpty()
--
To view, visit https://gerrit.wikimedia.org/r/352898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3bdb0aed6eb8b04e8a7282477fe51c49f7d763b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
