Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353051 )

Change subject: Updates to print styles
......................................................................

Updates to print styles

* hatnotes are hidden on mobile
* Adjusted vertical padding of headings
* Remove infobox styles introduced in 6a889e3f
these are redundant after 98b155f7 and should have been
removed. Font size however is retained.
* Reset font size of tables to 16px
* Drop hardcoded font-size declaration for infobox rows.
This interferes with styling rules and seems to be unnecessary.
* Restrict print styles to mobile devices
* Ensure thumbnails are left aligned

Bug: T163752
Change-Id: I84388db817e4d8d657e530063db1d727c6534c93
---
M resources/skins.minerva.content.styles/hacks.less
M resources/skins.minerva.print.styles/article.less
D resources/skins.minerva.print.styles/infobox.less
M resources/skins.minerva.print.styles/styles.less
4 files changed, 22 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/51/353051/1

diff --git a/resources/skins.minerva.content.styles/hacks.less 
b/resources/skins.minerva.content.styles/hacks.less
index 468bf44..f1a954a 100644
--- a/resources/skins.minerva.content.styles/hacks.less
+++ b/resources/skins.minerva.content.styles/hacks.less
@@ -47,7 +47,6 @@
                                vertical-align: top;
                                border: 0;
                                border-bottom: 1px solid @colorGray14;
-                               font-size: 13px;
                                padding: 7px 10px;
                        }
 
diff --git a/resources/skins.minerva.print.styles/article.less 
b/resources/skins.minerva.print.styles/article.less
index baf76af..c479ea5 100644
--- a/resources/skins.minerva.print.styles/article.less
+++ b/resources/skins.minerva.print.styles/article.less
@@ -4,6 +4,10 @@
 @dividerHeight: 2px;
 @dividerSpacing: 28px;
 
+.hatnote {
+       display: none;
+}
+
 .pre-content {
        display: block;
        padding: 51px 0 35px;
@@ -38,6 +42,11 @@
 
 .thumbinner {
        width: auto !important;
+       // Force image link to take up maximum available space so that
+       // the thumbnail inside can be aligned left rather than centered
+       > * {
+               width: 100%;
+       }
 }
 
 .thumb {
@@ -79,6 +88,8 @@
 
        .section-heading {
                border-bottom: 0;
+               padding-bottom: 0;
+               margin-bottom: 16px;
        }
 
        h2 {
@@ -87,9 +98,19 @@
 
        h3 {
                font-size: 40px;
+               margin-bottom: 13px;
        }
 
        h4, h5, h6 {
                font-size: 36px;
+               margin-bottom: 12px;
+       }
+
+       .wikitable {
+               font-size: 16px;
+       }
+
+       table.infobox {
+               font-size: 30px;
        }
 }
diff --git a/resources/skins.minerva.print.styles/infobox.less 
b/resources/skins.minerva.print.styles/infobox.less
deleted file mode 100644
index 93a13b2..0000000
--- a/resources/skins.minerva.print.styles/infobox.less
+++ /dev/null
@@ -1,23 +0,0 @@
-@import 'minerva.variables';
-@import 'minerva.mixins';
-
-.infobox {
-       font-size: 30px;
-       border-radius: 5px;
-       display: table !important;
-
-       tr {
-               border: solid 2px @printBorderColor;
-               border-bottom: solid 2px @printBorderColorLight;
-
-               &:last-child {
-                       border-bottom: solid 2px @printBorderColor;
-               }
-       }
-
-       td,
-       th {
-               text-align: left !important;
-               padding: 20px 0 20px 42px;
-       }
-}
diff --git a/resources/skins.minerva.print.styles/styles.less 
b/resources/skins.minerva.print.styles/styles.less
index dc799b0..375c9bc 100644
--- a/resources/skins.minerva.print.styles/styles.less
+++ b/resources/skins.minerva.print.styles/styles.less
@@ -1,4 +1,4 @@
-@media print {
+@media print and (max-device-width: 720px) {
        // Chrome: override the default margins and reveal the footer
        // Experimental technology (see 
https://developer.mozilla.org/en-US/docs/Web/CSS/@page/size)
        @page {
@@ -13,7 +13,6 @@
        @import 'header.less';
        @import 'article.less';
        @import 'blockquotes.less';
-       @import 'infobox.less';
        @import 'references.less';
        @import 'footer.less';
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/353051
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84388db817e4d8d657e530063db1d727c6534c93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to