Ema has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/353874 )

Change subject: VCL: lower grace for transient n-hit-wonder objects
......................................................................

VCL: lower grace for transient n-hit-wonder objects

Lower grace for hit-for-pass objects created when dealing with
n-hit-wonders from 5m/60m (healthy/sick backend) to 1m.

Bug: T165063
Change-Id: Ief0426ef58f0380ba1dd14f7eb94a6f3072c46e0
---
M modules/varnish/templates/text-frontend.inc.vcl.erb
M modules/varnish/templates/upload-frontend.inc.vcl.erb
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/74/353874/1

diff --git a/modules/varnish/templates/text-frontend.inc.vcl.erb 
b/modules/varnish/templates/text-frontend.inc.vcl.erb
index afb98e9..cc02258 100644
--- a/modules/varnish/templates/text-frontend.inc.vcl.erb
+++ b/modules/varnish/templates/text-frontend.inc.vcl.erb
@@ -230,8 +230,7 @@
             && bereq.http.X-CDIS == "miss"
             && beresp.http.X-Cache-Int !~ " hit/([4-9]|[0-9]{2,})$") {
                set beresp.ttl = 0s;
-               // XXX not doing this on Friday for safety, think more later:
-               // set beresp.grace = 0s;
+               set beresp.grace = 60s;
                set beresp.keep = 0s;
                set beresp.uncacheable = true;
                return (deliver);
diff --git a/modules/varnish/templates/upload-frontend.inc.vcl.erb 
b/modules/varnish/templates/upload-frontend.inc.vcl.erb
index d323e79..c43c7e8 100644
--- a/modules/varnish/templates/upload-frontend.inc.vcl.erb
+++ b/modules/varnish/templates/upload-frontend.inc.vcl.erb
@@ -82,8 +82,7 @@
             && beresp.http.X-Cache-Int !~ " hit/([4-9]|[0-9]{2,})$"
             && std.integer(beresp.http.Content-Length, 1024) >= 1024) {
                set beresp.ttl = 0s;
-               // XXX not doing this on Friday for safety, think more later:
-               // set beresp.grace = 0s;
+               set beresp.grace = 60s;
                set beresp.keep = 0s;
                set beresp.uncacheable = true;
                return (deliver);

-- 
To view, visit https://gerrit.wikimedia.org/r/353874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief0426ef58f0380ba1dd14f7eb94a6f3072c46e0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <e...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to