jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/352870 )
Change subject: eventLogging: Add missing *Hover properties ...................................................................... eventLogging: Add missing *Hover properties Action changes: * Include the namespace ID in LINK_DWELL. Reducer changes: * Add the createEvent helper, which adds the pageTitleHover and namespaceIdHover properties in the event. * Create "dismissed", "dwelledButAbandoned", and "opened" events using the createEvent helper. Additional changes: * Store the target page's associated mw.Title using jQuery. * Update the eventLogging reducer's test cases so that all LINK_DWELL representations include title and namespaceID attributes. * Create the createStubTitle factory function, which returns a minimal usable mw.Title stub, and use it in the actions and integration test cases. Bug: T164256 Change-Id: I8a63d82a65324680dff9176020a8ea97695428c4 --- M resources/dist/index.js M resources/dist/index.js.map M src/actions.js M src/processLinks.js M src/reducers/eventLogging.js M tests/node-qunit/actions.test.js M tests/node-qunit/integration.test.js M tests/node-qunit/processLinks.test.js M tests/node-qunit/reducers/eventLogging.test.js M tests/node-qunit/stubs.js 10 files changed, 161 insertions(+), 48 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/352870 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a63d82a65324680dff9176020a8ea97695428c4 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
