jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/353276 )
Change subject: Do not run internal or external survey browser tests on BC
......................................................................
Do not run internal or external survey browser tests on BC
Instead run an integration test there that verifies surveys can
be rendered.
Bug: T164907
Change-Id: I187af858c4f53286f20b4fb433e1f20b1c0865f2
---
M tests/browser/features/external_survey.feature
A tests/browser/features/integration.feature
M tests/browser/features/internal_survey.feature
3 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/external_survey.feature
b/tests/browser/features/external_survey.feature
index 2ab9f50..dbca503 100644
--- a/tests/browser/features/external_survey.feature
+++ b/tests/browser/features/external_survey.feature
@@ -1,4 +1,6 @@
-@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org
@vagrant @integration
+# Don't add the @en.m.wikipedia.beta.wmflabs.org tag
+# These browser tests only need to run per commit @integration
+@chrome @firefox @vagrant @integration
Feature: External surveys
Background:
Given the quick survey test pages are installed
diff --git a/tests/browser/features/integration.feature
b/tests/browser/features/integration.feature
new file mode 100644
index 0000000..f86506f
--- /dev/null
+++ b/tests/browser/features/integration.feature
@@ -0,0 +1,11 @@
+# This browser test runs on the beta cluster to protect us against upstream
breakages
+# for example OOjs UI
+@chrome @firefox @vagrant @integration @en.m.wikipedia.beta.wmflabs.org
+Feature: Integration
+
+ Scenario: Survey is visible with quicksurvey=true flag
+ Given the quick survey test pages are installed
+ When I am on the "Quick survey test page stub" page with the quick survey
flag enabled
+ And the page has fully loaded
+ And the survey code has fully loaded
+ Then I should see the survey
diff --git a/tests/browser/features/internal_survey.feature
b/tests/browser/features/internal_survey.feature
index a054865..1fc6d4c 100644
--- a/tests/browser/features/internal_survey.feature
+++ b/tests/browser/features/internal_survey.feature
@@ -1,4 +1,6 @@
-@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org
@vagrant @integration
+# Don't add the @en.m.wikipedia.beta.wmflabs.org tag
+# These browser tests only need to run per commit @integration
+@chrome @firefox @vagrant @integration
Feature: Internal surveys
Background:
Given the quick survey test pages are installed
--
To view, visit https://gerrit.wikimedia.org/r/353276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I187af858c4f53286f20b4fb433e1f20b1c0865f2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
