jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354128 )
Change subject: Add phpcs and make pass
......................................................................
Add phpcs and make pass
Change-Id: I28ca402cb2a71486b1736ae69ff1a7ac8fefc05d
---
M Campaigns.hooks.php
M CampaignsSecondaryAuthenticationProvider.php
M composer.json
A phpcs.xml
4 files changed, 18 insertions(+), 6 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Campaigns.hooks.php b/Campaigns.hooks.php
index 42b9d16..69a2679 100644
--- a/Campaigns.hooks.php
+++ b/Campaigns.hooks.php
@@ -64,7 +64,7 @@
$displayMobile = class_exists( 'MobileContext' ) &&
MobileContext::singleton()->shouldDisplayMobileView();
- $event = array(
+ $event = [
'userId' => $userId,
'userName' => $user->getName(),
'isSelfMade' => $isSelfMade,
@@ -73,7 +73,7 @@
// @todo: Remove these unused fields when they're no
longer required by the schema.
'token' => '',
'userBuckets' => '',
- );
+ ];
$returnTo = $wgRequest->getVal( 'returnto' );
if ( $returnTo !== null ) {
diff --git a/CampaignsSecondaryAuthenticationProvider.php
b/CampaignsSecondaryAuthenticationProvider.php
index 02a475e..ccea98a 100644
--- a/CampaignsSecondaryAuthenticationProvider.php
+++ b/CampaignsSecondaryAuthenticationProvider.php
@@ -51,7 +51,7 @@
$displayMobile = class_exists( 'MobileContext' ) &&
MobileContext::singleton()->shouldDisplayMobileView();
- $event = array(
+ $event = [
'userId' => $userId,
'userName' => $user->getName(),
'isSelfMade' => $isSelfMade,
@@ -60,7 +60,7 @@
// @todo: Remove these unused fields when they're no
longer required by the schema.
'token' => '',
'userBuckets' => '',
- );
+ ];
$returnTo = $request->getVal( 'returnto', $req ? $req->returnTo
: null );
if ( $returnTo !== null ) {
diff --git a/composer.json b/composer.json
index 686b65b..b8f68fb 100644
--- a/composer.json
+++ b/composer.json
@@ -1,11 +1,14 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "jakub-onderka/php-console-highlighter": "0.3.2"
+ "jakub-onderka/php-console-highlighter": "0.3.2",
+ "mediawiki/mediawiki-codesniffer": "0.7.2"
},
"scripts": {
+ "fix": "phpcbf",
"test": [
- "parallel-lint . --exclude vendor"
+ "parallel-lint . --exclude vendor",
+ "phpcs -p -s"
]
}
}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..ede6c5d
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <file>.</file>
+ <arg name="extensions" value="php,php5,inc"/>
+ <arg name="encoding" value="utf8"/>
+ <exclude-pattern>vendor</exclude-pattern>
+ <exclude-pattern>node_modules</exclude-pattern>
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/354128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28ca402cb2a71486b1736ae69ff1a7ac8fefc05d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Campaigns
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
