jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354102 )
Change subject: Fix mmv.model.TaskQueue qunit tests
......................................................................
Fix mmv.model.TaskQueue qunit tests
Bug: T164473
Change-Id: Iaefae1d00a0469f11ddb3fcecb4f831346ac0eec
---
M tests/qunit/mmv/model/mmv.model.TaskQueue.test.js
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/tests/qunit/mmv/model/mmv.model.TaskQueue.test.js
b/tests/qunit/mmv/model/mmv.model.TaskQueue.test.js
index 7284f00..bfbb67d 100644
--- a/tests/qunit/mmv/model/mmv.model.TaskQueue.test.js
+++ b/tests/qunit/mmv/model/mmv.model.TaskQueue.test.js
@@ -36,14 +36,15 @@
QUnit.test( 'State check', 3, function ( assert ) {
var taskQueue = new mw.mmv.model.TaskQueue(),
- task = $.Deferred();
+ task = $.Deferred(),
+ promise;
taskQueue.push( function () { return task; } );
assert.strictEqual( taskQueue.state,
mw.mmv.model.TaskQueue.State.NOT_STARTED,
'state is initially NOT_STARTED' );
- taskQueue.execute().then( function () {
+ promise = taskQueue.execute().then( function () {
assert.strictEqual( taskQueue.state,
mw.mmv.model.TaskQueue.State.FINISHED,
'state is FINISHED after execution finished' );
} );
@@ -51,7 +52,9 @@
assert.strictEqual( taskQueue.state,
mw.mmv.model.TaskQueue.State.RUNNING,
'state is RUNNING after execution started' );
- return task.resolve();
+ task.resolve();
+
+ return promise;
} );
QUnit.test( 'State check for cancellation', 1, function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/354102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaefae1d00a0469f11ddb3fcecb4f831346ac0eec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
