Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354252 )
Change subject: Add phpcs and make pass
......................................................................
Add phpcs and make pass
Change-Id: Ib4dbe698323ad9c419d1c979fe838665ae454b98
---
M XAnalytics.class.php
M composer.json
A phpcs.xml
3 files changed, 17 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/XAnalytics
refs/changes/52/354252/1
diff --git a/XAnalytics.class.php b/XAnalytics.class.php
index 4c65b9e..6bc939e 100644
--- a/XAnalytics.class.php
+++ b/XAnalytics.class.php
@@ -38,8 +38,8 @@
}
self::$addedHeader = true;
$response = $out->getRequest()->response();
- $headerItems = array();
- Hooks::run( 'XAnalyticsSetHeader', array( $out, &$headerItems )
);
+ $headerItems = [];
+ Hooks::run( 'XAnalyticsSetHeader', [ $out, &$headerItems ] );
if ( count( $headerItems ) ) {
self::createHeader( $response, $headerItems );
}
@@ -74,7 +74,7 @@
if ( self::$addedHeader ) {
// If the header is already set, we need to append to
it and replace it
global $wgRequest;
- self::createHeader( $wgRequest->response(), array(
$name => $value ) );
+ self::createHeader( $wgRequest->response(), [ $name =>
$value ] );
}
}
}
diff --git a/composer.json b/composer.json
index 686b65b..b8f68fb 100644
--- a/composer.json
+++ b/composer.json
@@ -1,11 +1,14 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "jakub-onderka/php-console-highlighter": "0.3.2"
+ "jakub-onderka/php-console-highlighter": "0.3.2",
+ "mediawiki/mediawiki-codesniffer": "0.7.2"
},
"scripts": {
+ "fix": "phpcbf",
"test": [
- "parallel-lint . --exclude vendor"
+ "parallel-lint . --exclude vendor",
+ "phpcs -p -s"
]
}
}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..ede6c5d
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <file>.</file>
+ <arg name="extensions" value="php,php5,inc"/>
+ <arg name="encoding" value="utf8"/>
+ <exclude-pattern>vendor</exclude-pattern>
+ <exclude-pattern>node_modules</exclude-pattern>
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/354252
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4dbe698323ad9c419d1c979fe838665ae454b98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/XAnalytics
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
