jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/354139 )
Change subject: Add phpcs and make pass ...................................................................... Add phpcs and make pass Change-Id: I73eeb7a6549de71bc229df2ad35dc9cbbe2c12bb --- M composer.json M includes/DashikiView.php A phpcs.xml 3 files changed, 16 insertions(+), 3 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/composer.json b/composer.json index 686b65b..b8f68fb 100644 --- a/composer.json +++ b/composer.json @@ -1,11 +1,14 @@ { "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "jakub-onderka/php-console-highlighter": "0.3.2" + "jakub-onderka/php-console-highlighter": "0.3.2", + "mediawiki/mediawiki-codesniffer": "0.7.2" }, "scripts": { + "fix": "phpcbf", "test": [ - "parallel-lint . --exclude vendor" + "parallel-lint . --exclude vendor", + "phpcs -p -s" ] } } diff --git a/includes/DashikiView.php b/includes/DashikiView.php index 51c5e3f..48a4fd3 100644 --- a/includes/DashikiView.php +++ b/includes/DashikiView.php @@ -41,7 +41,8 @@ public function renderHeader( $dbkey ) { $buildMessage = wfMessage( 'dashiki-build' ); $span = Html::element( 'span', null, $buildMessage ); - $pre = Html::element( 'pre', null, 'gulp --config ' . wfEscapeShellArg( $dbkey ) . ' --layout /*...*/' ); + $pre = Html::element( 'pre', null, + 'gulp --config ' . wfEscapeShellArg( $dbkey ) . ' --layout /*...*/' ); return $span . $pre; } } diff --git a/phpcs.xml b/phpcs.xml new file mode 100644 index 0000000..ede6c5d --- /dev/null +++ b/phpcs.xml @@ -0,0 +1,9 @@ +<?xml version="1.0" encoding="UTF-8"?> +<ruleset> + <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/> + <file>.</file> + <arg name="extensions" value="php,php5,inc"/> + <arg name="encoding" value="utf8"/> + <exclude-pattern>vendor</exclude-pattern> + <exclude-pattern>node_modules</exclude-pattern> +</ruleset> -- To view, visit https://gerrit.wikimedia.org/r/354139 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73eeb7a6549de71bc229df2ad35dc9cbbe2c12bb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Dashiki Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits