VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354369 )
Change subject: MediaWiki, Apex theme: Increase Fieldset a Layout header's
`font-size`
......................................................................
MediaWiki, Apex theme: Increase Fieldset a Layout header's `font-size`
This has been decreased in , but we need to set it more carefully
apart from the labels and widgets. Increasing just to be rendered
by 1px higher, as the most prominent use case is Special Pages, where
every pixel counts.
Also aligning FieldsetLayout with icon's padding to icon padding
elsewhere.
Bug: T155575
Change-Id: I947c6cd4d15f62e04c14ef09838e787d3f6cde5a
---
M src/themes/apex/layouts.less
M src/themes/mediawiki/common.less
M src/themes/mediawiki/layouts.less
3 files changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/69/354369/1
diff --git a/src/themes/apex/layouts.less b/src/themes/apex/layouts.less
index 88bfa96..80d6963 100644
--- a/src/themes/apex/layouts.less
+++ b/src/themes/apex/layouts.less
@@ -133,7 +133,7 @@
&.oo-ui-labelElement > .oo-ui-fieldsetLayout-header >
.oo-ui-labelElement-label {
display: inline-block;
- font-size: 1.1em;
+ font-size: 1.15em;
margin-bottom: 0.5em;
padding: 0.25em 0;
font-weight: bold;
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 695f63f..b4af696 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -98,6 +98,7 @@
@margin-taboption: @margin-dialog-bar-button-framed;
@margin-top-tagitem: 4 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
@margin-top-tagmultiselect-input: 6 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
+@margin-bottom-fieldset-header: 8 / @oo-ui-font-size-browser / (
@oo-ui-font-size-default * @font-size-fieldset-header );
@border-default: @border-width-default solid @border-color-default;
@border-disabled: @border-width-default solid @border-color-disabled;
@@ -151,6 +152,7 @@
@padding-start-input-text-icon: 6 / @oo-ui-font-size-browser /
@oo-ui-font-size-default; // As long as we have whitespace in icon canvas, we
need reduced `padding-left`.
@padding-start-icon: @size-icon;
@padding-start-icon-only: 26 / @oo-ui-font-size-browser /
@oo-ui-font-size-default; // equals `2.03125em`≈`26px`;
@min-width-button-default - @padding-horizontal-default - 2 *
@border-width-default;
+@padding-start-fieldset-header-iconized: 26 / @oo-ui-font-size-browser / (
@oo-ui-font-size-default * @font-size-fieldset-header );
@padding-start-indicator-only: @padding-start-icon-only;
@padding-start-indicator-plus: 32 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
@padding-start-input-text-icon-label: 32 / @oo-ui-font-size-browser /
@oo-ui-font-size-default;
@@ -168,9 +170,12 @@
@box-shadow-erroneous-focus: inset 0 0 0 1px @color-erroneous;
@box-shadow-disabled-filled: inset 0 0 0 1px @color-disabled-filled;
+@font-size-fieldset-header: 1.15em; // equals `16.1px` at base `font-size:
12.8px`. Todo: Not able to get unified `16px` due to T
+
@line-height-default: 1.6; // same as Vector
@line-height-reset: 1; // Support: Safari, reset `line-height` in order to
normalize it in a follow-up rule across browsers.
@line-height-message: 1.4;
+@line-height-fieldset-header-iconized: 24 / @oo-ui-font-size-browser / (
@oo-ui-font-size-default * @font-size-fieldset-header );
@line-height-form-element: 1.4;
@line-height-input-binary-label: 1.5; // Checkboxes, Radios and
ToggleSwitchWidget labels need a tad more for increased vertical click area
@line-height-widget-multiline: 1.275;
diff --git a/src/themes/mediawiki/layouts.less
b/src/themes/mediawiki/layouts.less
index a6185d7..86eb027 100644
--- a/src/themes/mediawiki/layouts.less
+++ b/src/themes/mediawiki/layouts.less
@@ -148,15 +148,15 @@
&.oo-ui-labelElement > .oo-ui-fieldsetLayout-header >
.oo-ui-labelElement-label {
display: inline-block;
- margin-bottom: 0.56818em; // equals `8px` due to `font-size:
1.1em` below
- font-size: 1.1em;
+ margin-bottom: @margin-bottom-fieldset-header;
+ font-size: @font-size-fieldset-header;
font-weight: bold;
line-height: @line-height-form-element;
}
&.oo-ui-iconElement > .oo-ui-fieldsetLayout-header >
.oo-ui-labelElement-label {
- padding-left: 2em;
- line-height: 1.8;
+ padding-left: @padding-start-fieldset-header-iconized;
+ line-height: @line-height-fieldset-header-iconized;
}
&.oo-ui-iconElement > .oo-ui-fieldsetLayout-header >
.oo-ui-iconElement-icon {
--
To view, visit https://gerrit.wikimedia.org/r/354369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I947c6cd4d15f62e04c14ef09838e787d3f6cde5a
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
