Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354465 )
Change subject: Add phpcs and make pass
......................................................................
Add phpcs and make pass
Change-Id: I9de930ba1a18bc2de17cccb42a516860cee811bf
---
M Insider.class.php
M Insider.i18n.magic.php
M composer.json
A phpcs.xml
4 files changed, 24 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Insider
refs/changes/65/354465/1
diff --git a/Insider.class.php b/Insider.class.php
index a20b122..99e699c 100644
--- a/Insider.class.php
+++ b/Insider.class.php
@@ -58,13 +58,12 @@
return true;
}
-
/**
* @param array $insiders
* @return array
*/
protected static function getInsiderUrls( array $insiders ) {
- $insiderUrls = array();
+ $insiderUrls = [];
foreach ( $insiders as $insider ) {
// Tribute to Evan
@@ -72,11 +71,11 @@
$userTitle = Title::newFromText( $insider, NS_USER );
if ( $userTitle ) {
- $insiderUrls[] = array(
+ $insiderUrls[] = [
'href' => $userTitle->getLocalURL(),
'text' => $userTitle->getText(),
'class' => 'interwiki-insider'
- );
+ ];
}
}
@@ -102,7 +101,7 @@
$linkRenderer =
MediaWikiServices::getInstance()->getLinkRenderer();
// build insider <li>'s
- $list = array();
+ $list = [];
foreach ( $insiders as $insider ) {
// Tribute to Evan
$insider = urldecode( $insider );
@@ -120,14 +119,14 @@
$title = Title::newFromText( wfMessage( 'insider-about-page'
)->inContentLanguage()->plain() );
if ( $title ) {
$list[] =
- Html::rawElement( 'li', array( 'class' =>
'interwiki-insider' ),
+ Html::rawElement( 'li', [ 'class' =>
'interwiki-insider' ],
$linkRenderer->makeLink( $title,
$skin->msg( 'insider-about' )->text() )
);
}
// build complete html
$bar[$skin->msg( 'insider-title' )->text()] =
- Html::rawElement( 'ul', array(),
+ Html::rawElement( 'ul', [],
implode( '', $list )
);
diff --git a/Insider.i18n.magic.php b/Insider.i18n.magic.php
index 1708021..6a79739 100644
--- a/Insider.i18n.magic.php
+++ b/Insider.i18n.magic.php
@@ -6,8 +6,8 @@
* @subpackage Extensions
*/
-$magicWords = array();
+$magicWords = [];
-$magicWords['en'] = array(
- 'insider' => array( 0, 'insider' ),
-);
+$magicWords['en'] = [
+ 'insider' => [ 0, 'insider' ],
+];
diff --git a/composer.json b/composer.json
index 686b65b..b8f68fb 100644
--- a/composer.json
+++ b/composer.json
@@ -1,11 +1,14 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "jakub-onderka/php-console-highlighter": "0.3.2"
+ "jakub-onderka/php-console-highlighter": "0.3.2",
+ "mediawiki/mediawiki-codesniffer": "0.7.2"
},
"scripts": {
+ "fix": "phpcbf",
"test": [
- "parallel-lint . --exclude vendor"
+ "parallel-lint . --exclude vendor",
+ "phpcs -p -s"
]
}
}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..ede6c5d
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <file>.</file>
+ <arg name="extensions" value="php,php5,inc"/>
+ <arg name="encoding" value="utf8"/>
+ <exclude-pattern>vendor</exclude-pattern>
+ <exclude-pattern>node_modules</exclude-pattern>
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/354465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9de930ba1a18bc2de17cccb42a516860cee811bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Insider
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
