WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354674 )
Change subject: Use single spaces in JS code
......................................................................
Use single spaces in JS code
Change-Id: Id85d6b89adef125374259a917da51a47f97b1519
---
M .eslintrc.json
M lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
M repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
M view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
M view/resources/jquery/ui/jquery.ui.TemplatedWidget.js
M view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
M view/resources/jquery/wikibase/jquery.wikibase.listview.js
M view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
M view/resources/jquery/wikibase/snakview/snakview.ViewState.js
M view/resources/jquery/wikibase/snakview/snakview.js
M view/resources/wikibase/entityChangers/SiteLinkSetsChanger.js
M view/resources/wikibase/templates.js
M view/resources/wikibase/utilities/wikibase.utilities.GuidGenerator.js
13 files changed, 12 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/74/354674/1
diff --git a/.eslintrc.json b/.eslintrc.json
index ba84a66..51de2fc 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -21,7 +21,6 @@
"new-cap": "off",
"new-parens": "off",
"no-extra-boolean-cast": "off",
- "no-multi-spaces": "off",
"no-underscore-dangle": "off",
"no-unused-vars": "off",
"one-var": "off",
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
index b7845c2..8de592a 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js
@@ -138,7 +138,7 @@
$( this.options.menu )
.on( 'selected.siteselector', function( event, item ) {
if ( item instanceof
$.wikibase.siteselector.Item ) {
- self._selectedSite = item.getSite();
+ self._selectedSite = item.getSite();
self.element.val(
self._createItemValue( self._selectedSite ) );
self._trigger( 'selected', null,
[self._selectedSite.getId()] );
}
diff --git a/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
b/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
index 3355938..4cb9568 100644
--- a/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
+++ b/repo/resources/jquery.wikibase/jquery.wikibase.entitysearch.js
@@ -74,7 +74,7 @@
this._close();
}
- return PARENT.prototype._setOption.apply( this, arguments );
+ return PARENT.prototype._setOption.apply( this, arguments );
},
/**
diff --git a/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
b/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
index 668b5b1..ea3f27f 100644
--- a/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
+++ b/view/resources/jquery/ui/jquery.ui.EditableTemplatedWidget.js
@@ -6,7 +6,7 @@
( function( $ ) {
'use strict';
- var PARENT = $.ui.TemplatedWidget;
+ var PARENT = $.ui.TemplatedWidget;
/**
* TemplatedWidget enhanced with editing capabilities.
diff --git a/view/resources/jquery/ui/jquery.ui.TemplatedWidget.js
b/view/resources/jquery/ui/jquery.ui.TemplatedWidget.js
index b0cbb65..15f6972 100644
--- a/view/resources/jquery/ui/jquery.ui.TemplatedWidget.js
+++ b/view/resources/jquery/ui/jquery.ui.TemplatedWidget.js
@@ -1,7 +1,7 @@
( function( $ ) {
'use strict';
- var PARENT = $.Widget;
+ var PARENT = $.Widget;
/**
* Base prototype for all widgets using the `mw.wbTemplate` templating
system.
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
b/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
index 006ec5c..2850b6e 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.entityselector.js
@@ -305,7 +305,7 @@
if ( entityStub.aliases ) {
$label.append(
- $( '<span
class="ui-entityselector-aliases"/>' ).text( ' (' + entityStub.aliases.join( ',
' ) + ')' )
+ $( '<span
class="ui-entityselector-aliases"/>' ).text( ' (' + entityStub.aliases.join( ',
' ) + ')' )
);
}
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.listview.js
b/view/resources/jquery/wikibase/jquery.wikibase.listview.js
index 0cf28c0..239287e 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.listview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.listview.js
@@ -1,7 +1,7 @@
( function( $ ) {
'use strict';
- var PARENT = $.ui.TemplatedWidget;
+ var PARENT = $.ui.TemplatedWidget;
/**
* View for displaying and editing list items, each represented by a single
random widget.
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
index ba8e530..b60c832 100644
---
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
+++
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
@@ -137,7 +137,7 @@
self._unbindGlobalEventListeners();
};
- $( document ).on( 'mouseup.' + self.widgetName,
degrade );
+ $( document ).on( 'mouseup.' + self.widgetName,
degrade );
$( window ).on( 'resize.' + self.widgetName,
function( event ) { self.repositionMenu(); } );
} );
diff --git a/view/resources/jquery/wikibase/snakview/snakview.ViewState.js
b/view/resources/jquery/wikibase/snakview/snakview.ViewState.js
index 455a5e2..7ee761e 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.ViewState.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.ViewState.js
@@ -20,7 +20,7 @@
*
* @throws {Error} if a required parameter is not specified properly.
*/
- var SELF = $.wikibase.snakview.ViewState = function
WbSnakviewViewState( snakView ) {
+ var SELF = $.wikibase.snakview.ViewState = function
WbSnakviewViewState( snakView ) {
if ( !( snakView instanceof $.wikibase.snakview ) ) {
throw new Error( 'Can not create a snakview ViewState
object without a snakview' );
}
diff --git a/view/resources/jquery/wikibase/snakview/snakview.js
b/view/resources/jquery/wikibase/snakview/snakview.js
index e26db9c..cc5175a 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.js
@@ -476,7 +476,7 @@
};
}
- var snakDeserializer = new wb.serialization.SnakDeserializer();
+ var snakDeserializer = new wb.serialization.SnakDeserializer();
try {
return snakDeserializer.deserialize( value );
} catch ( e ) {
diff --git a/view/resources/wikibase/entityChangers/SiteLinkSetsChanger.js
b/view/resources/wikibase/entityChangers/SiteLinkSetsChanger.js
index b58bd64..92990b5 100644
--- a/view/resources/wikibase/entityChangers/SiteLinkSetsChanger.js
+++ b/view/resources/wikibase/entityChangers/SiteLinkSetsChanger.js
@@ -76,7 +76,7 @@
var diffValue = getDiffValue();
var siteLinksChanger = this._siteLinksChanger;
- var resultValue = diffValue.unchanged;
+ var resultValue = diffValue.unchanged;
return chain( diffValue.changed.map( function( siteLink
) {
return function() {
diff --git a/view/resources/wikibase/templates.js
b/view/resources/wikibase/templates.js
index dfa990d..bf58916 100644
--- a/view/resources/wikibase/templates.js
+++ b/view/resources/wikibase/templates.js
@@ -19,7 +19,7 @@
* @return {string}
*/
function getParameterType( param ) {
- return ( param instanceof jQuery ) ? 'jQuery' : typeof param;
+ return ( param instanceof jQuery ) ? 'jQuery' : typeof param;
}
/**
diff --git
a/view/resources/wikibase/utilities/wikibase.utilities.GuidGenerator.js
b/view/resources/wikibase/utilities/wikibase.utilities.GuidGenerator.js
index 9300b8c..fc06df0 100644
--- a/view/resources/wikibase/utilities/wikibase.utilities.GuidGenerator.js
+++ b/view/resources/wikibase/utilities/wikibase.utilities.GuidGenerator.js
@@ -69,7 +69,7 @@
}
while ( hex.length < 4 ) {
- hex = '0' + hex;
+ hex = '0' + hex;
}
guid += hex;
--
To view, visit https://gerrit.wikimedia.org/r/354674
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id85d6b89adef125374259a917da51a47f97b1519
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
