jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354470 )
Change subject: Allow creating redirect only dumps with dumpRdf
......................................................................
Allow creating redirect only dumps with dumpRdf
Bug: T98320
Change-Id: I4796d01c592e84fe883380b655f215a76dd49dd6
---
M repo/maintenance/dumpRdf.php
M repo/tests/phpunit/maintenance/dumpRdfTest.php
2 files changed, 39 insertions(+), 2 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
diff --git a/repo/maintenance/dumpRdf.php b/repo/maintenance/dumpRdf.php
index b11867f..c337f22 100644
--- a/repo/maintenance/dumpRdf.php
+++ b/repo/maintenance/dumpRdf.php
@@ -79,6 +79,7 @@
false,
true
);
+ $this->addOption( 'redirect-only', 'Whether to only dump
information about redirects.', false, false );
}
/**
@@ -139,12 +140,18 @@
}
/**
- * Returns EntityIdPager::INCLUDE_REDIRECTS.
+ * Returns one of the EntityIdPager::XXX_REDIRECTS constants.
*
* @return mixed a EntityIdPager::XXX_REDIRECTS constant
*/
protected function getRedirectMode() {
- return EntityIdPager::INCLUDE_REDIRECTS;
+ $redirectOnly = $this->getOption( 'redirect-only', false );
+
+ if ( $redirectOnly ) {
+ return EntityIdPager::ONLY_REDIRECTS;
+ } else {
+ return EntityIdPager::INCLUDE_REDIRECTS;
+ }
}
/**
diff --git a/repo/tests/phpunit/maintenance/dumpRdfTest.php
b/repo/tests/phpunit/maintenance/dumpRdfTest.php
index 45a80fc..3807efb 100644
--- a/repo/tests/phpunit/maintenance/dumpRdfTest.php
+++ b/repo/tests/phpunit/maintenance/dumpRdfTest.php
@@ -39,6 +39,7 @@
use Wikibase\Repo\Store\Sql\SqlEntityIdPagerFactory;
use Wikibase\Repo\Tests\Store\MockEntityIdPager;
use Wikibase\Repo\WikibaseRepo;
+use Wikimedia\TestingAccessWrapper;
/**
* @covers Wikibase\DumpRdf
@@ -192,6 +193,35 @@
}
/**
+ * @dataProvider getRedirectModeProvider
+ */
+ public function testGetRedirectMode( $expected, $redirectOnly ) {
+ $dumpScript = TestingAccessWrapper::newFromObject( new
DumpRdf() );
+
+ $dumpArgv = [ 0 => 'foo' ];
+ if ( $redirectOnly ) {
+ $dumpArgv[] = '--redirect-only';
+ }
+
+ $dumpScript->loadWithArgv( $dumpArgv );
+
+ $this->assertSame( $expected, $dumpScript->getRedirectMode() );
+ }
+
+ public function getRedirectModeProvider() {
+ return [
+ [
+ EntityIdPager::INCLUDE_REDIRECTS,
+ false
+ ],
+ [
+ EntityIdPager::ONLY_REDIRECTS,
+ true
+ ]
+ ];
+ }
+
+ /**
* @return PropertyDataTypeLookup
*/
private function getMockPropertyDataTypeLookup() {
--
To view, visit https://gerrit.wikimedia.org/r/354470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4796d01c592e84fe883380b655f215a76dd49dd6
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Lucie Kaffee <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
