Brion VIBBER has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354998 )
Change subject: Put print click handler on link, not on list item
......................................................................
Put print click handler on link, not on list item
Was responding to clicks outside the link, which was confusing.
Bug: T24256
Change-Id: I22f7cf20a08bb4204b0442defeb7cfb83899b969
---
M resources/src/mediawiki/page/ready.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/98/354998/1
diff --git a/resources/src/mediawiki/page/ready.js
b/resources/src/mediawiki/page/ready.js
index 758e20a..1f6c8a6 100644
--- a/resources/src/mediawiki/page/ready.js
+++ b/resources/src/mediawiki/page/ready.js
@@ -59,7 +59,7 @@
mw.hook( 'wikipage.categories' ).fire( $nodes );
}
- $( '#t-print' ).click( function ( e ) {
+ $( '#t-print a' ).click( function ( e ) {
window.print();
e.preventDefault();
} );
--
To view, visit https://gerrit.wikimedia.org/r/354998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22f7cf20a08bb4204b0442defeb7cfb83899b969
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
