Mark Bergsma has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355123 )

Change subject: Add BGPUpdateMessage attribute method test cases
......................................................................

Add BGPUpdateMessage attribute method test cases

Change-Id: Id0f790b04e25ffec7ad4acc263598af3d0f07d6d
---
M pybal/bgp/test_bgp.py
1 file changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/pybal 
refs/changes/23/355123/1

diff --git a/pybal/bgp/test_bgp.py b/pybal/bgp/test_bgp.py
index 9db5ff6..a5aba1c 100644
--- a/pybal/bgp/test_bgp.py
+++ b/pybal/bgp/test_bgp.py
@@ -31,6 +31,13 @@
         self.msg = bgp.BGPUpdateMessage()
         self.assertEquals(self.msg.msgLenOffset, 16)
         self.assertEquals(len(self.msg.msg), 4)
+        self.assertEquals(len(self.msg), 23)
+
+        self.attrs = bgp.FrozenAttributeDict(
+                    [bgp.OriginAttribute(),
+                    bgp.ASPathAttribute([64600, 64601]),
+                    bgp.NextHopAttribute("192.0.2.1"),
+                    bgp.MEDAttribute(100)])
 
     def testAddSomeWithdrawals(self):
         self.assertEquals(self.msg.addSomeWithdrawals(set()), 0)
@@ -45,3 +52,14 @@
         # Not all prefixes will fit within maxLen
         self.assertEquals(self.msg.addSomeWithdrawals(prefixset), 813)
         self.assertEquals(len(prefixset), 211)
+
+    def testAddAttributes(self):
+        self.msg.addAttributes(bgp.FrozenAttributeDict({}))
+        self.assertEqual(len(self.msg), 23)
+        self.msg.addAttributes(self.attrs)
+        self.assertEqual(len(self.msg), 50)
+
+    def testClearAttributes(self):
+        self.msg.addAttributes(self.attrs)
+        self.msg.clearAttributes()
+        self.assertEquals(len(self.msg), 23)

-- 
To view, visit https://gerrit.wikimedia.org/r/355123
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0f790b04e25ffec7ad4acc263598af3d0f07d6d
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/pybal
Gerrit-Branch: master
Gerrit-Owner: Mark Bergsma <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to