Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/355125 )

Change subject: Phabricator: Use mkdir -p for creating phd directory in systemd
......................................................................


Phabricator: Use mkdir -p for creating phd directory in systemd

Reason is sometimes the directory exists so it will cause mkdir to fail.

Use -p to ignore if the directory already exists.


--parent "no error if existing, make parent directories as needed"


Change-Id: I7179b8472edb290d5a3aadbc15f1e9889b212895
---
M modules/phabricator/templates/initscripts/phd.systemd.erb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/phabricator/templates/initscripts/phd.systemd.erb 
b/modules/phabricator/templates/initscripts/phd.systemd.erb
index 328e00b..42113e7 100644
--- a/modules/phabricator/templates/initscripts/phd.systemd.erb
+++ b/modules/phabricator/templates/initscripts/phd.systemd.erb
@@ -8,7 +8,7 @@
 User=phd
 Group=phd
 Environment="PHABRICATOR_ENV=phd"
-ExecStartPre=-/bin/mkdir /var/run/phd
+ExecStartPre=-/bin/mkdir -p /var/run/phd/
 ExecStartPre=/bin/chown -R phd:phd /var/run/phd/
 ExecStart=/srv/phab/phabricator/bin/phd start
 ExecStop=/srv/phab/phabricator/bin/phd stop --force

-- 
To view, visit https://gerrit.wikimedia.org/r/355125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7179b8472edb290d5a3aadbc15f1e9889b212895
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: 20after4 <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to